MF-1455 - Update Versions of Protobuf #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
dborovcanin
requested changes
Jan 26, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1704 +/- ##
==========================================
+ Coverage 70.30% 70.32% +0.01%
==========================================
Files 148 148
Lines 11501 11501
==========================================
+ Hits 8086 8088 +2
+ Misses 2747 2745 -2
Partials 668 668
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
dborovcanin
approved these changes
Jan 27, 2023
dborovcanin
previously approved these changes
Jan 27, 2023
drasko
requested changes
Feb 1, 2023
| @@ -92,21 +92,24 @@ func TestTransformCBOR(t *testing.T) { | |||
| require.Nil(t, err, "Decoding CBOR expected to succeed") | |||
|
|
|||
| tr := senml.New(senml.CBOR) | |||
| msg := messaging.Message{ | |||
|
|
|||
| // 82AD2169626173652D6E616D6522F956402369626173652D756E6974200A24F9490025F9564000646E616D650164756E697406F95CB0036331323307F958B002F9514005F94900AA2169626173652D6E616D6522F956402369626173652D756E6974200A24F9490025F9564000646E616D6506F95CB007F958B005F94900 | |||
There was a problem hiding this comment.
What is this? Some dead code? Or a regular comment?
There was a problem hiding this comment.
It was initially there
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
dborovcanin
approved these changes
Feb 2, 2023
rodneyosodo
added a commit
to rodneyosodo/magistrala
that referenced
this pull request
Feb 6, 2023
* initial commit * add protoc-gen-gofast * update generated files * fix linting * fix consumers error on message conversion * fix copying values on transformers * initial commit * initial commit * add protoc-gen-gofast * update generated files * fix linting * fix consumers error on message conversion * fix copying values on transformers * embedded for forward compatible. * remove gogo * embedded for forward compatible. * update protoc compiler * fix linting * remove hex comment Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rodneyosodo socials@rodneyosodo.com
What does this do?
Updates versions of protobuf
Which issue(s) does this PR fix/relate to?
Resolves #1455
List any changes that modify/break current functionality
When updating the protobuf version, it is possible that some changes may break backward compatibility. The change in the protobuf version enforces that the message is passed in as a pointer since it contains a sync mutex. Therefore, any existing code that attempted to pass the message without a pointer would no longer function correctly.
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes
N/A