Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Update Nginx Docker Image #1706

Merged
merged 10 commits into from
Jan 29, 2023
Merged

Conversation

rodneyosodo
Copy link
Member

@rodneyosodo rodneyosodo commented Jan 18, 2023

Signed-off-by: rodneyosodo socials@rodneyosodo.com

What does this do?

Updates nginx docker image from nginx:1.20.0-alpine to nginx:1.23.3-alpine. In doing so, it fixes typo is docker/ssl/Makefile and also return error of type ErrBearerKey on publish request instead of ErrBearerToken

Which issue(s) does this PR fix/relate to?

N/A

List any changes that modify/break current functionality

No

Have you included tests for your changes?

No

Did you document any new/modified functionality?

No

Notes

N/A

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
@rodneyosodo rodneyosodo changed the title NOISSUE - Fix Minor Issues on Mutual TLS Authentication NOISSUE - Update Nginx Config For Mutual TLS Authentication Jan 19, 2023
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
@rodneyosodo rodneyosodo changed the title NOISSUE - Update Nginx Config For Mutual TLS Authentication NOISSUE - Update Nginx Docker Image Jan 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2023

Codecov Report

Merging #1706 (9386478) into master (5f9b3c9) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #1706   +/-   ##
=======================================
  Coverage   70.32%   70.32%           
=======================================
  Files         148      148           
  Lines       11501    11501           
=======================================
  Hits         8088     8088           
  Misses       2745     2745           
  Partials      668      668           
Impacted Files Coverage Δ
http/api/transport.go 71.42% <ø> (ø)
http/api/requests.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rodneyosodo rodneyosodo marked this pull request as ready for review January 23, 2023 09:32
@rodneyosodo rodneyosodo requested a review from a team as a code owner January 23, 2023 09:32
drasko
drasko previously approved these changes Jan 24, 2023
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also generate CA and server certs since the old ones are expired?
(You can use Makefile from docker/ssl with commands make ca and make server_cert).

docker/ssl/authorization.js Outdated Show resolved Hide resolved
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
docker/ssl/authorization.js Outdated Show resolved Hide resolved
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
docker/ssl/authorization.js Outdated Show resolved Hide resolved
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 2e118ce into absmach:master Jan 29, 2023
rodneyosodo added a commit to rodneyosodo/magistrala that referenced this pull request Feb 2, 2023
* initial commit

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>

* update tests

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>

* initial commit

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>

* update tests

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>

* add empty line

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>

* update certs

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>

* remove serial file

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>

* fix check password from certs

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>

* change from include to endswith

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>

---------

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Co-authored-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
rodneyosodo added a commit to rodneyosodo/magistrala that referenced this pull request Feb 6, 2023
* initial commit

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>

* update tests

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>

* initial commit

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>

* update tests

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>

* add empty line

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>

* update certs

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>

* remove serial file

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>

* fix check password from certs

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>

* change from include to endswith

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>

---------

Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Co-authored-by: rodneyosodo <socials@rodneyosodo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants