-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE - Update Nginx Docker Image #1706
Conversation
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1706 +/- ##
=======================================
Coverage 70.32% 70.32%
=======================================
Files 148 148
Lines 11501 11501
=======================================
Hits 8088 8088
Misses 2745 2745
Partials 668 668
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also generate CA and server certs since the old ones are expired?
(You can use Makefile from docker/ssl
with commands make ca
and make server_cert
).
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
ef12c26
to
2e6fa28
Compare
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* initial commit Signed-off-by: rodneyosodo <socials@rodneyosodo.com> * update tests Signed-off-by: rodneyosodo <socials@rodneyosodo.com> * initial commit Signed-off-by: rodneyosodo <socials@rodneyosodo.com> * update tests Signed-off-by: rodneyosodo <socials@rodneyosodo.com> * add empty line Signed-off-by: rodneyosodo <socials@rodneyosodo.com> * update certs Signed-off-by: rodneyosodo <socials@rodneyosodo.com> * remove serial file Signed-off-by: rodneyosodo <socials@rodneyosodo.com> * fix check password from certs Signed-off-by: rodneyosodo <socials@rodneyosodo.com> * change from include to endswith Signed-off-by: rodneyosodo <socials@rodneyosodo.com> --------- Signed-off-by: rodneyosodo <socials@rodneyosodo.com> Co-authored-by: rodneyosodo <socials@rodneyosodo.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
* initial commit Signed-off-by: rodneyosodo <socials@rodneyosodo.com> * update tests Signed-off-by: rodneyosodo <socials@rodneyosodo.com> * initial commit Signed-off-by: rodneyosodo <socials@rodneyosodo.com> * update tests Signed-off-by: rodneyosodo <socials@rodneyosodo.com> * add empty line Signed-off-by: rodneyosodo <socials@rodneyosodo.com> * update certs Signed-off-by: rodneyosodo <socials@rodneyosodo.com> * remove serial file Signed-off-by: rodneyosodo <socials@rodneyosodo.com> * fix check password from certs Signed-off-by: rodneyosodo <socials@rodneyosodo.com> * change from include to endswith Signed-off-by: rodneyosodo <socials@rodneyosodo.com> --------- Signed-off-by: rodneyosodo <socials@rodneyosodo.com> Co-authored-by: rodneyosodo <socials@rodneyosodo.com>
Signed-off-by: rodneyosodo socials@rodneyosodo.com
What does this do?
Updates nginx docker image from
nginx:1.20.0-alpine
tonginx:1.23.3-alpine
. In doing so, it fixes typo isdocker/ssl/Makefile
and also return error of typeErrBearerKey
on publish request instead ofErrBearerToken
Which issue(s) does this PR fix/relate to?
N/A
List any changes that modify/break current functionality
No
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes
N/A