MF-1707 - Make Certs TTL Configurable #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rodneyosodo <socials@rodneyosodo.com>
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #1708 +/- ##
==========================================
+ Coverage 70.30% 70.35% +0.05%
==========================================
Files 148 148
Lines 11501 11501
==========================================
+ Hits 8086 8092 +6
+ Misses 2747 2743 -4
+ Partials 668 666 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dborovcanin
approved these changes
Jan 24, 2023
rodneyosodo
added a commit
to rodneyosodo/magistrala
that referenced
this pull request
Feb 2, 2023
Signed-off-by: rodneyosodo <socials@rodneyosodo.com> Signed-off-by: rodneyosodo <socials@rodneyosodo.com> Co-authored-by: rodneyosodo <socials@rodneyosodo.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
rodneyosodo
added a commit
to rodneyosodo/magistrala
that referenced
this pull request
Feb 6, 2023
Signed-off-by: rodneyosodo <socials@rodneyosodo.com> Signed-off-by: rodneyosodo <socials@rodneyosodo.com> Co-authored-by: rodneyosodo <socials@rodneyosodo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rodneyosodo socials@rodneyosodo.com
What does this do?
Makes the certs TTL configurable to a time duration i.e
h,m,drather than having it being set to hours by default.Which issue(s) does this PR fix/relate to?
Resolves #1707
List any changes that modify/break current functionality
N/A
Have you included tests for your changes?
No
Did you document any new/modified functionality?
Yes
Notes
N/A