Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MF-1720 - Improve Test Reports #1727

Merged
merged 6 commits into from
Apr 12, 2023
Merged

MF-1720 - Improve Test Reports #1727

merged 6 commits into from
Apr 12, 2023

Conversation

AryanGodara
Copy link
Contributor

What does this do?

Updates test files, for better test reports, and overall making test functions more uniform.

Which issue(s) does this PR fix/relate to?

Resolves #1720

@AryanGodara AryanGodara requested a review from a team as a code owner February 18, 2023 16:12
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@eb77f3d). Click here to learn what that means.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##             master    #1727   +/-   ##
=========================================
  Coverage          ?   70.60%           
=========================================
  Files             ?      146           
  Lines             ?    11421           
  Branches          ?        0           
=========================================
  Hits              ?     8064           
  Misses            ?     2716           
  Partials          ?      641
Impacted Files Coverage Δ
things/postgres/things.go 68.47% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dborovcanin dborovcanin requested review from arvindh123 and rodneyosodo and removed request for arvindh123 February 23, 2023 08:03
rodneyosodo
rodneyosodo requested changes Feb 24, 2023
View reviewed changes
Copy link
Member

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move to assert.Nil or stick to require.Nil ?

rodneyosodo
rodneyosodo requested changes Feb 24, 2023
View reviewed changes
Copy link
Member

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AryanGodara move from require.Nil to assert.Nil where necessary. I am still seeing it under boostrap tests among others

dborovcanin
dborovcanin previously approved these changes Mar 15, 2023
View reviewed changes
rodneyosodo
rodneyosodo requested changes Mar 20, 2023
View reviewed changes
Copy link
Member

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to ignore comments on auth services. As it will change later on. My suggestion is if a variable is used downstream, for instance when we are testing RetrieveAll we need to used require when creating entities the later on when testing RetrieveAll we use assert

auth/api/grpc/endpoint_test.go Outdated Show resolved Hide resolved
auth/jwt/token_test.go Outdated Show resolved Hide resolved
auth/jwt/token_test.go Outdated Show resolved Hide resolved
auth/jwt/token_test.go Outdated Show resolved Hide resolved
auth/postgres/groups_test.go Outdated Show resolved Hide resolved
bootstrap/postgres/configs_test.go Outdated Show resolved Hide resolved
bootstrap/postgres/configs_test.go Outdated Show resolved Hide resolved
bootstrap/postgres/configs_test.go Outdated Show resolved Hide resolved
bootstrap/postgres/configs_test.go Outdated Show resolved Hide resolved
bootstrap/postgres/configs_test.go Outdated Show resolved Hide resolved
dborovcanin
dborovcanin previously approved these changes Mar 29, 2023
View reviewed changes
@AryanGodara
resolve merge conflicts
3235c52 
Signed-off-by: aryan <aryangodara03@gmail.com>
@AryanGodara
change remaining require with assert
d5c02f1 
Signed-off-by: aryan <aryangodara03@gmail.com>
@AryanGodara
replace assert with require, whenever required.
a55986b 
Signed-off-by: aryan <aryangodara03@gmail.com>
@AryanGodara
fix failing tests
99ffb1e 
Signed-off-by: aryan <aryangodara03@gmail.com>
@AryanGodara
resolve assert and require
0d7a03e 
Signed-off-by: aryan <aryangodara03@gmail.com>
@AryanGodara
revert groups_test
2f33ef9 
Signed-off-by: aryan <aryangodara03@gmail.com>
drasko
drasko approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit b435b80 into absmach:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dborovcanin dborovcanin dborovcanin approved these changes

@drasko drasko drasko approved these changes

@rodneyosodo rodneyosodo Awaiting requested review from rodneyosodo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve test reports
5 participants
@AryanGodara @codecov-commenter @drasko @dborovcanin @rodneyosodo