NOISSUE - Logger Fatal method returns no value #1728
Conversation
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
dborovcanin
force-pushed
the
fix-fatal-signature
branch
from
05d1a2e
to
1d10302
Compare
cmd/auth/main.go
Outdated
| } | ||
|
|
||
| logger, err := logger.New(os.Stdout, cfg.LogLevel) | ||
| if err != nil { | ||
| log.Fatalf(err.Error()) | ||
| log.Fatal(fmt.Sprintf("failed to init logger: %s", err)) |
There was a problem hiding this comment.
This is a native Go log because logger was not initialized properly. But let me also rename it because we have:
logger, err := logger.New(os.Stdout, cfg.LogLevel)Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
logger/logger_test.go
Outdated
| res, err := writer.Read() | ||
| require.Nil(t, err, "required successful buffer read") | ||
| assert.Equal(t, e.ExitCode(), 1, fmt.Sprintf("%s: expected exit code %d, got %d", tc.desc, 1, e.ExitCode())) | ||
| assert.Equal(t, res, tc.output, fmt.Sprintf("%s: expected output %s got %s", tc.desc, tc.output, res)) |
There was a problem hiding this comment.
When you assert, do you put first what you expect and then what you got as the params? As in these two lines this seems to be inverse and is a little bit confusing - because it is not consistent.
I will approve, but please change if you see fit.
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1728 +/- ##
=======================================
Coverage 70.35% 70.36%
=======================================
Files 146 146
Lines 11399 11398 -1
=======================================
Hits 8020 8020
+ Misses 2729 2728 -1
Partials 650 650
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
What does this do?
This pull request makes Mainflux Logger Fatal method return no value.
Which issue(s) does this PR fix/relate to?
There is no such issue.
List any changes that modify/break current functionality
There are no changes in current functionalities.
Have you included tests for your changes?
Yes, tests for Fatal are added and other tests are refactored.
Did you document any new/modified functionality?
N/A
Notes
N/A