NOISSUE - Fix Send Response for Publishing Message #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammyOina
previously approved these changes
Mar 8, 2023
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
dborovcanin
force-pushed
the
NOISSUE-coapreturn
branch
from
114c885
to
317c2e9
Compare
dborovcanin
previously approved these changes
Mar 16, 2023
dborovcanin
reviewed
Mar 16, 2023
coap/api/transport.go
Outdated
| } | ||
| sendResp(w, &resp) |
There was a problem hiding this comment.
Consider using defer sendResp(w, &resp) as a little more elegant alternative.
dborovcanin
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds functionality to send response for successfully publishing messages.
Which issue(s) does this PR fix/relate to?
NOISSUE
List any changes that modify/break current functionality
Previously, we only sent response when we encountered an error. This meant when you try ab publish message using coap-cli it would not automatically close after successfully publishing the message. It would close after the timeout has reached. This was because we were not returning a response upon successful publishing of message
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes
How to reproduce the problem would be to try and publish message using coap-cli