Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOISSUE - Add prometheus and grafana for metrics #1753

Merged
merged 12 commits into from
Apr 14, 2023
Merged

NOISSUE - Add prometheus and grafana for metrics #1753

merged 12 commits into from
Apr 14, 2023

Conversation

SammyOina
Copy link
Contributor

What does this do?

Add Prometheus and grafana for service metrics

Which issue(s) does this PR fix/relate to?

None

List any changes that modify/break current functionality

None

Have you included tests for your changes?

No

Did you document any new/modified functionality?

No

Notes

@SammyOina SammyOina requested a review from a team as a code owner March 27, 2023 19:54
rodneyosodo
rodneyosodo requested changes Mar 28, 2023
View reviewed changes
docker/addons/prometheus/docker-compose.yaml Outdated Show resolved Hide resolved
docker/addons/prometheus/docker-compose.yaml Outdated Show resolved Hide resolved
docker/.env Outdated Show resolved Hide resolved
docker/.env Outdated Show resolved Hide resolved
docker/.env Outdated Show resolved Hide resolved
docker/.env Outdated Show resolved Hide resolved
@dborovcanin dborovcanin changed the title NOISSUE - add prometheus and grafana for metrics NOISSUE - Add prometheus and grafana for metrics Mar 28, 2023
rodneyosodo
rodneyosodo requested changes Mar 28, 2023
View reviewed changes
docker/addons/prometheus/docker-compose.yaml Outdated Show resolved Hide resolved
docker/addons/prometheus/grafana/datasource.yml Outdated Show resolved Hide resolved
docker/.env Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@eb77f3d). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##             master    #1753   +/-   ##
=========================================
  Coverage          ?   70.59%           
=========================================
  Files             ?      146           
  Lines             ?    11418           
  Branches          ?        0           
=========================================
  Hits              ?     8061           
  Misses            ?     2716           
  Partials          ?      641

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rodneyosodo
Copy link
Member

Is it possible that you can provide some dashboard in .json also so that someone can import a basic monitoring dashboard?

@SammyOina
Copy link
Contributor Author

Is it possible that you can provide some dashboard in .json also so that someone can import a basic monitoring dashboard?

Like creating a sample grafana dashboard? @rodneyosodo

@rodneyosodo
Copy link
Member

Is it possible that you can provide some dashboard in .json also so that someone can import a basic monitoring dashboard?

Like creating a sample grafana dashboard? @rodneyosodo

Yes

rodneyosodo
rodneyosodo requested changes Apr 11, 2023
View reviewed changes
Copy link
Member

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at why only auth metrics are showing up and not the others in prometheus

docker/addons/prometheus/docker-compose.yaml Outdated Show resolved Hide resolved
docker/addons/prometheus/grafana/datasource.yml Outdated Show resolved Hide resolved
docker/addons/prometheus/grafana/dashboard.yml Outdated Show resolved Hide resolved
docker/addons/prometheus/docker-compose.yaml Outdated Show resolved Hide resolved
docker/addons/prometheus/docker-compose.yaml Outdated Show resolved Hide resolved
docker/addons/prometheus/docker-compose.yaml Outdated Show resolved Hide resolved
docker/addons/prometheus/docker-compose.yaml Outdated Show resolved Hide resolved
docker/addons/prometheus/docker-compose.yaml Outdated Show resolved Hide resolved
dborovcanin
dborovcanin requested changes Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an empty line to the end of yml files.

@SammyOina
Copy link
Contributor Author

Have a look at why only auth metrics are showing up and not the others in prometheus

now fixed

@SammyOina
Copy link
Contributor Author

Add an empty line to the end of yml files.

Done

dborovcanin
dborovcanin requested changes Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use yml over yaml extension to be in sync with other compose files.
Also, please improve existing Dashboard examples since most dashboards are empty due to the queries used.

docker/addons/prometheus/grafana/example-dashboard.json Outdated Show resolved Hide resolved
rodneyosodo
rodneyosodo requested changes Apr 12, 2023
View reviewed changes
Copy link
Member

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove threshold from the request count

rodneyosodo
rodneyosodo requested changes Apr 12, 2023
View reviewed changes
Copy link
Member

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the legends For example
image

docker/addons/prometheus/grafana/example-dashboard.json Show resolved Hide resolved
rodneyosodo
rodneyosodo requested changes Apr 13, 2023
View reviewed changes
Copy link
Member

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Check the output graph for total request. It don't think it is updating correctly

@SammyOina @dborovcanin
add prometheus and grafana for metrics
fc6c236 
Signed-off-by: SammyOina <sammyoina@gmail.com>
@SammyOina @dborovcanin
add grafana tag
5c13b6b 
move prometheus metrics

Signed-off-by: SammyOina <sammyoina@gmail.com>
@SammyOina @dborovcanin
add empty lines
25070ae 
Signed-off-by: SammyOina <sammyoina@gmail.com>
@SammyOina @dborovcanin
add example dashboard
be5cf0d 
Signed-off-by: SammyOina <sammyoina@gmail.com>
@SammyOina @dborovcanin
fix scraping path
96e8548 
Signed-off-by: SammyOina <sammyoina@gmail.com>
@SammyOina @dborovcanin
add things metric to dashboard
a160cfd 
Signed-off-by: SammyOina <sammyoina@gmail.com>
@SammyOina @dborovcanin
change execution path
fa1ffee 
Signed-off-by: SammyOina <sammyoina@gmail.com>
@SammyOina @dborovcanin
fix typo and switch from yaml to yml
2dd5386 
Signed-off-by: SammyOina <sammyoina@gmail.com>
@SammyOina @dborovcanin
update dashboard
5e533a2 
Signed-off-by: SammyOina <sammyoina@gmail.com>
@SammyOina @dborovcanin
update example dashboard
fd75cc3 
Signed-off-by: SammyOina <sammyoina@gmail.com>
@SammyOina @dborovcanin
update dashboard
8ea33fc 
Signed-off-by: SammyOina <sammyoina@gmail.com>
@SammyOina
remove thresholds from gauges
0cbfbec 
Signed-off-by: SammyOina <sammyoina@gmail.com>
rodneyosodo

This comment was marked as resolved.

Sign in to view

@SammyOina
Copy link
Contributor Author

Change threshold on allocated bytes
image

Do we know what is critical value? I'd rather just leave it to be static white always

rodneyosodo
rodneyosodo requested changes Apr 14, 2023
View reviewed changes
Copy link
Member

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I stop one container I still get allocated bytes

image

@rodneyosodo
Copy link
Member

When I stop one container I still get allocated bytes

image

This is resolved

drasko
drasko approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 0e3e716 into absmach:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodneyosodo rodneyosodo rodneyosodo approved these changes

@dborovcanin dborovcanin dborovcanin approved these changes

@drasko drasko drasko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SammyOina @codecov-commenter @rodneyosodo @drasko @dborovcanin