MF-1761 - Improve path parameters naming #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodneyosodo
requested changes
Apr 11, 2023
codeball-ai-writer
bot
added
codeball:needs-careful-review
and removed
codeball:needs-review
labels
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1762 +/- ##
==========================================
+ Coverage 70.50% 70.53% +0.02%
==========================================
Files 146 146
Lines 11482 11514 +32
==========================================
+ Hits 8095 8121 +26
- Misses 2745 2748 +3
- Partials 642 645 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rodneyosodo
requested changes
Apr 11, 2023
There was a problem hiding this comment.
Also change https://github.com/mainflux/mainflux/blob/master/auth/api/http/groups/transport.go#L67 to groupId
rodneyosodo
requested changes
Apr 12, 2023
dborovcanin
reviewed
Apr 12, 2023
There was a problem hiding this comment.
Looks good, please resolve the remarks left b y @rodneyosodo.
rodneyosodo
requested changes
Apr 12, 2023
rodneyosodo
requested changes
Apr 13, 2023
|
I've made the necessary changes requested. |
rodneyosodo
requested changes
Apr 13, 2023
There was a problem hiding this comment.
I am still getting errors on api/asyncapi/websocket.yml. You can use this to check
dborovcanin
requested changes
Apr 13, 2023
rodneyosodo
requested changes
Apr 14, 2023
rodneyosodo
previously approved these changes
Apr 14, 2023
dborovcanin
requested changes
Apr 14, 2023
dborovcanin
requested changes
Apr 17, 2023
rodneyosodo
requested changes
Apr 17, 2023
rodneyosodo
requested changes
Apr 17, 2023
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
improve path parameter naming for: bootstrap/api/transport.go twins/api/http/transport.go Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Duplicated the functions decodeView and decodeListByConnection to form new functions decodeThingView, decodeChannelView, decodeThingListByConnection and decodeChannelListByConnection. This was as a result of the two functions being used for both view thing and view channel services Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Improve path parameter naming for:
auth/api/http/groups/transport.go
bootstrap/api/transport.go
twins/api/http/transport.go
ws/api/endpoints.go
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Updated the following swagger files
api/openapi/auth.yml
api/openapi/cert.yml
api/openapi/websocket.yml
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
deleted websocket.yml file in openapi and created websocket.yml file in asyncapi Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Update the websocket.yml file to make subtopic optional and added security (bearerAuth) Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
format newline for api/asyncapi/websocket.yml Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
update the websocket.yml file based on the requested review changes
The document is now valid
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
make changes to path parameter naming in:
api/openapi/consumers-notifiers.yml
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Update path parameters naming to be consistent with Go Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
update the mqtt.yml file to the latest AsyncAPI version and make changes on the security of the server Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Co-authored-by: b1ackd0t <blackd0t@protonmail.com> Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
dborovcanin
requested changes
Apr 17, 2023
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
dborovcanin
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Improve path parameters naming
Which issue(s) does this PR fix/relate to?
Resolves #1761
List any changes that modify/break current functionality
None
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes