Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Trace MQTT forward operations #1775

Merged
merged 20 commits into from
May 31, 2023

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Apr 20, 2023

Pull request title should be MF-XXX - description or NOISSUE - description where XXX is ID of issue that this PR relate to.
Please review the CONTRIBUTING.md file for detailed contributing guidelines.

What does this do?

Trace MQTT forward operations

Which issue(s) does this PR fix/relate to?

There is no such issue.

List any changes that modify/break current functionality

None

Have you included tests for your changes?

Ni

Did you document any new/modified functionality?

No

Notes

mqtt/forwarder.go Outdated Show resolved Hide resolved
mqtt/forwarder.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Merging #1775 (a56e729) into master (029140a) will decrease coverage by 0.01%.
The diff coverage is 78.94%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1775      +/-   ##
==========================================
- Coverage   70.00%   69.99%   -0.01%     
==========================================
  Files         149      149              
  Lines       11803    11816      +13     
==========================================
+ Hits         8263     8271       +8     
- Misses       2870     2875       +5     
  Partials      670      670              
Impacted Files Coverage Δ
http/api/transport.go 69.30% <0.00%> (-2.13%) ⬇️
things/api/auth/grpc/server.go 79.48% <0.00%> (-2.10%) ⬇️
mqtt/handler.go 92.98% <88.00%> (+0.52%) ⬆️
bootstrap/service.go 83.10% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dborovcanin
Copy link
Collaborator

@SammyOina The goal of this initiative is not to add a tracer to the Forward method but to improve tracing on the MQTT Proxy side. This implies some changes in the Handler interface in mProxy. We need context there anyways, so it's an excellent opportunity to add it now.

go.mod Outdated Show resolved Hide resolved
mqtt/tracing/forwarder.go Outdated Show resolved Hide resolved
@dborovcanin dborovcanin force-pushed the mqtt-forwarder-trace branch 2 times, most recently from 78eba9c to 06c6963 Compare May 29, 2023 14:26
@SammyOina
Copy link
Contributor Author

image
image

Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 1eaa805 into absmach:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants