NOISSUE - Trace consume operations #1778

SammyOina · 2023-04-24T11:00:27Z

What does this do?

Add tracing on consume operations

Which issue(s) does this PR fix/relate to?

https://github.com/ultravioletrs/issues/issues/210

List any changes that modify/break current functionality

none

Have you included tests for your changes?

none

Did you document any new/modified functionality?

no

Notes

consumers/tracing/consumers.go

codecov-commenter · 2023-04-28T12:43:25Z

Codecov Report

Merging #1778 (c523c65) into master (41be96a) will not change coverage.
The diff coverage is 93.10%.

@@           Coverage Diff           @@
##           master    #1778   +/-   ##
=======================================
  Coverage   64.73%   64.73%           
=======================================
  Files         118      118           
  Lines        9702     9702           
=======================================
  Hits         6281     6281           
  Misses       2753     2753           
  Partials      668      668

Impacted Files	Coverage Δ
consumers/notifiers/service.go	`60.00% <50.00%> (ø)`
consumers/writers/cassandra/consumer.go	`77.55% <100.00%> (ø)`
consumers/writers/influxdb/consumer.go	`89.87% <100.00%> (ø)`
consumers/writers/mongodb/consumer.go	`79.31% <100.00%> (ø)`
consumers/writers/postgres/consumer.go	`65.76% <100.00%> (ø)`
consumers/writers/timescale/consumer.go	`66.99% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

rodneyosodo

On second thought since consumeBlockingOP or consumeAsyncOP are in the same context with consumeMessageOP and when a client publishes a message Channel Subtopic and Publisher will be the same, why not combine the two into something like

func (tm *tracingMiddlewareAsync) ConsumeAsync(ctx context.Context, messages interface{}) {
	var span opentracing.Span
	switch m := messages.(type) {
	case mfjson.Messages:
		firstMsg := m.Data[0]
		span, ctx = createMessageSpan(ctx, tm.tracer, firstMsg.Channel, firstMsg.Subtopic, firstMsg.Publisher, consumeAsyncOP)
		span.SetTag("number_of_messages", len(m.Data))
		defer span.Finish()
	case []senml.Message:
		firstMsg := m[0]
		span, ctx = createMessageSpan(ctx, tm.tracer, firstMsg.Channel, firstMsg.Subtopic, firstMsg.Publisher, consumeAsyncOP)
		span.SetTag("number_of_messages", len(m))
		defer span.Finish()
	}
	tm.consumerAsync.ConsumeAsync(ctx, messages)
}

consumers/tracing/consumers.go

rodneyosodo

LGTM

consumers/tracing/consumers.go

drasko

LGTM

SammyOina · 2023-05-29T21:05:28Z

consumers/tracing/consumers.go

arvindh123

I have tested all the writers and verified in Jaeger,
Everything works fine
And
Looks good to me

Signed-off-by: SammyOina <sammyoina@gmail.com>

Co-authored-by: b1ackd0t <blackd0t@protonmail.com> Signed-off-by: SammyOina <sammyoina@gmail.com>

Signed-off-by: SammyOina <sammyoina@gmail.com>

drasko

LGTM

* trace consume operations Signed-off-by: SammyOina <sammyoina@gmail.com> * add create span function Signed-off-by: SammyOina <sammyoina@gmail.com> * add consume message op Signed-off-by: SammyOina <sammyoina@gmail.com> * Update consumers/tracing/consumers.go Co-authored-by: b1ackd0t <blackd0t@protonmail.com> Signed-off-by: SammyOina <sammyoina@gmail.com> * trace messages grouped Signed-off-by: SammyOina <sammyoina@gmail.com> * rework comments Signed-off-by: SammyOina <sammyoina@gmail.com> * rename value Signed-off-by: SammyOina <sammyoina@gmail.com> * check message len Signed-off-by: SammyOina <sammyoina@gmail.com> * rename struct member Signed-off-by: SammyOina <sammyoina@gmail.com> * move to open telemetry Signed-off-by: SammyOina <sammyoina@gmail.com> * fix linting Signed-off-by: SammyOina <sammyoina@gmail.com> * improve context management Signed-off-by: SammyOina <sammyoina@gmail.com> * add span details Signed-off-by: SammyOina <sammyoina@gmail.com> * rename operations Signed-off-by: SammyOina <sammyoina@gmail.com> * add comment Signed-off-by: SammyOina <sammyoina@gmail.com> --------- Signed-off-by: SammyOina <sammyoina@gmail.com> Co-authored-by: b1ackd0t <blackd0t@protonmail.com>

SammyOina requested a review from a team as a code owner April 24, 2023 11:00

rodneyosodo requested changes Apr 28, 2023

View reviewed changes

consumers/tracing/consumers.go Outdated Show resolved Hide resolved

consumers/tracing/consumers.go Outdated Show resolved Hide resolved

SammyOina requested a review from rodneyosodo April 28, 2023 12:30

rodneyosodo requested changes May 2, 2023

View reviewed changes

consumers/tracing/consumers.go Outdated Show resolved Hide resolved

SammyOina force-pushed the consumers-tracing branch from 8300c9f to c34ea34 Compare May 2, 2023 19:10

rodneyosodo requested changes May 3, 2023

View reviewed changes

consumers/tracing/consumers.go Outdated Show resolved Hide resolved

consumers/tracing/consumers.go Outdated Show resolved Hide resolved

consumers/tracing/consumers.go Outdated Show resolved Hide resolved

SammyOina requested a review from rodneyosodo May 3, 2023 11:53

rodneyosodo previously approved these changes May 3, 2023

View reviewed changes

dborovcanin force-pushed the consumers-tracing branch from 7193b54 to 3570a43 Compare May 10, 2023 12:41

SammyOina force-pushed the consumers-tracing branch from 3570a43 to f7bd264 Compare May 11, 2023 22:22

dborovcanin force-pushed the consumers-tracing branch from f7bd264 to 531f5c1 Compare May 29, 2023 14:18

dborovcanin requested changes May 29, 2023

View reviewed changes

consumers/tracing/consumers.go Outdated Show resolved Hide resolved

dborovcanin force-pushed the consumers-tracing branch from 531f5c1 to 77d586a Compare May 29, 2023 14:26

SammyOina force-pushed the consumers-tracing branch from 77d586a to 59c2821 Compare May 29, 2023 14:35

SammyOina dismissed rodneyosodo’s stale review via 77b4a38 May 29, 2023 14:35

SammyOina requested a review from dborovcanin May 29, 2023 14:36

drasko previously approved these changes May 29, 2023

View reviewed changes

dborovcanin requested changes May 29, 2023

View reviewed changes

consumers/tracing/consumers.go Outdated Show resolved Hide resolved

consumers/tracing/consumers.go Outdated Show resolved Hide resolved

consumers/tracing/consumers.go Outdated Show resolved Hide resolved

consumers/tracing/consumers.go Outdated Show resolved Hide resolved

SammyOina dismissed drasko’s stale review via a7d31c5 May 30, 2023 05:56

SammyOina requested a review from dborovcanin May 30, 2023 06:01

dborovcanin requested changes May 30, 2023

View reviewed changes

consumers/tracing/consumers.go Outdated Show resolved Hide resolved

consumers/tracing/consumers.go Outdated Show resolved Hide resolved

consumers/tracing/consumers.go Outdated Show resolved Hide resolved

SammyOina force-pushed the consumers-tracing branch 2 times, most recently from f7d284e to 9726de2 Compare May 30, 2023 13:08

SammyOina requested a review from dborovcanin May 30, 2023 21:55

SammyOina force-pushed the consumers-tracing branch from 9726de2 to c91594f Compare May 31, 2023 12:28

SammyOina requested a review from drasko May 31, 2023 12:28

SammyOina force-pushed the consumers-tracing branch 2 times, most recently from f34837e to 1a0c93d Compare May 31, 2023 18:11

SammyOina force-pushed the consumers-tracing branch from f35db72 to 3c22665 Compare July 13, 2023 13:25

rodneyosodo requested changes Jul 13, 2023

View reviewed changes

consumers/tracing/consumers.go Outdated Show resolved Hide resolved

SammyOina force-pushed the consumers-tracing branch 2 times, most recently from fb00796 to 22bbac8 Compare July 13, 2023 14:18

dborovcanin force-pushed the consumers-tracing branch from 22bbac8 to 144bb7d Compare July 13, 2023 14:48

SammyOina force-pushed the consumers-tracing branch from 144bb7d to f89128b Compare July 13, 2023 17:48

rodneyosodo requested changes Jul 14, 2023

View reviewed changes

consumers/tracing/consumers.go Outdated Show resolved Hide resolved

arvindh123 reviewed Jul 18, 2023

View reviewed changes

SammyOina force-pushed the consumers-tracing branch from a82f399 to 82f79c2 Compare July 19, 2023 12:18

SammyOina and others added 14 commits July 19, 2023 15:19

trace consume operations

f43bcf0

Signed-off-by: SammyOina <sammyoina@gmail.com>

add create span function

aa1cb11

Signed-off-by: SammyOina <sammyoina@gmail.com>

add consume message op

edceb6d

Signed-off-by: SammyOina <sammyoina@gmail.com>

Update consumers/tracing/consumers.go

e3c108d

Co-authored-by: b1ackd0t <blackd0t@protonmail.com> Signed-off-by: SammyOina <sammyoina@gmail.com>

trace messages grouped

a7b262e

Signed-off-by: SammyOina <sammyoina@gmail.com>

rework comments

fef7a68

Signed-off-by: SammyOina <sammyoina@gmail.com>

rename value

57dbb8a

Signed-off-by: SammyOina <sammyoina@gmail.com>

check message len

3e86938

Signed-off-by: SammyOina <sammyoina@gmail.com>

rename struct member

18579e1

Signed-off-by: SammyOina <sammyoina@gmail.com>

move to open telemetry

30416f3

Signed-off-by: SammyOina <sammyoina@gmail.com>

fix linting

392a1b9

Signed-off-by: SammyOina <sammyoina@gmail.com>

improve context management

5573f98

Signed-off-by: SammyOina <sammyoina@gmail.com>

add span details

da90e80

Signed-off-by: SammyOina <sammyoina@gmail.com>

rename operations

a20622e

Signed-off-by: SammyOina <sammyoina@gmail.com>

SammyOina force-pushed the consumers-tracing branch from 82f79c2 to a20622e Compare July 19, 2023 12:19

add comment

c523c65

Signed-off-by: SammyOina <sammyoina@gmail.com>

drasko approved these changes Jul 19, 2023

View reviewed changes

drasko merged commit 70f53c2 into absmach:master Jul 22, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NOISSUE - Trace consume operations #1778

NOISSUE - Trace consume operations #1778

SammyOina commented Apr 24, 2023 •

edited

Loading

codecov-commenter commented Apr 28, 2023 •

edited by codecov bot

Loading

rodneyosodo left a comment

rodneyosodo left a comment

drasko left a comment

SammyOina commented May 29, 2023

arvindh123 left a comment •

edited

Loading

drasko left a comment

NOISSUE - Trace consume operations #1778

NOISSUE - Trace consume operations #1778

Conversation

SammyOina commented Apr 24, 2023 • edited Loading

What does this do?

Which issue(s) does this PR fix/relate to?

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

Notes

codecov-commenter commented Apr 28, 2023 • edited by codecov bot Loading

Codecov Report

rodneyosodo left a comment

Choose a reason for hiding this comment

rodneyosodo left a comment

Choose a reason for hiding this comment

drasko left a comment

Choose a reason for hiding this comment

SammyOina commented May 29, 2023

arvindh123 left a comment • edited Loading

Choose a reason for hiding this comment

drasko left a comment

Choose a reason for hiding this comment

SammyOina commented Apr 24, 2023 •

edited

Loading

codecov-commenter commented Apr 28, 2023 •

edited by codecov bot

Loading

arvindh123 left a comment •

edited

Loading