MF-1783 - Improve HTTP / gRPC codes when attempting to publish with nonexistent thing key / channel id #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1798 +/- ##
==========================================
- Coverage 70.00% 69.97% -0.03%
==========================================
Files 149 149
Lines 11803 11808 +5
==========================================
Hits 8263 8263
- Misses 2870 2875 +5
Partials 670 670
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dborovcanin
approved these changes
May 25, 2023
dborovcanin
force-pushed
the
MF-1783
branch
2 times, most recently
from
8a101d9
to
a272540
Compare
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
dborovcanin
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Improves error reports for invalid channels and things.
Which issue(s) does this PR fix/relate to?
Resolves #1783
List any changes that modify/break current functionality
Non-existent channel id and thing key returned 500 internal error which is now switched to 404 not found.
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes