Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF-1801 - Improve error value returned for invalid thing #1803

Merged
merged 3 commits into from
May 29, 2023

Conversation

SammyOina
Copy link
Contributor

Pull request title should be MF-XXX - description or NOISSUE - description where XXX is ID of issue that this PR relate to.
Please review the CONTRIBUTING.md file for detailed contributing guidelines.

What does this do?

Improves error returned when a thing does not exist during bootstrapping.

Which issue(s) does this PR fix/relate to?

Resolves #1801

List any changes that modify/break current functionality

None

Have you included tests for your changes?

No

Did you document any new/modified functionality?

No

Notes

@SammyOina SammyOina requested a review from a team as a code owner May 25, 2023 14:44
@SammyOina SammyOina changed the title MF-1801 - Improve error value returned for non-existent thing MF-1801 - Improve error value returned for invalid thing May 25, 2023
Signed-off-by: SammyOina <sammyoina@gmail.com>
bootstrap/service.go Outdated Show resolved Hide resolved
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1803 (e82d210) into master (029140a) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #1803   +/-   ##
=======================================
  Coverage   70.00%   70.00%           
=======================================
  Files         149      149           
  Lines       11803    11803           
=======================================
  Hits         8263     8263           
  Misses       2870     2870           
  Partials      670      670           
Impacted Files Coverage Δ
bootstrap/service.go 83.10% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit acfa0aa into absmach:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error response for invalid thing_id on bootstaping
4 participants