NOISSUE - Improve graceful shutdown and code quality #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1821 +/- ##
==========================================
+ Coverage 64.73% 64.89% +0.15%
==========================================
Files 118 119 +1
Lines 9702 9745 +43
==========================================
+ Hits 6281 6324 +43
Misses 2753 2753
Partials 668 668
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
SammyOina
changed the title
SammyOina
force-pushed
the
code-quality
branch
4 times, most recently
from
621164c
to
7b2e889
Compare
arvindh123
reviewed
Jul 4, 2023
SammyOina
force-pushed
the
code-quality
branch
5 times, most recently
from
3242153
to
6efef79
Compare
SammyOina
force-pushed
the
code-quality
branch
3 times, most recently
from
f093ab1
to
1479657
Compare
|
@dborovcanin @SammyOina |
|
@SammyOina Why we are removing single switch case ? |
SammyOina
force-pushed
the
code-quality
branch
2 times, most recently
from
d644cac
to
681fb99
Compare
arvindh123
reviewed
Jul 24, 2023
|
LGTM |
remove duplicate cases Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
rodneyosodo
pushed a commit
to rodneyosodo/magistrala
that referenced
this pull request
Aug 3, 2023
* remove single case switch remove duplicate cases Signed-off-by: SammyOina <sammyoina@gmail.com> * remove single case switch \n format comments Signed-off-by: SammyOina <sammyoina@gmail.com> * graceful exit on main func Signed-off-by: SammyOina <sammyoina@gmail.com> * remove fatal from imported packages Signed-off-by: SammyOina <sammyoina@gmail.com> * reuse exit function Signed-off-by: SammyOina <sammyoina@gmail.com> * return nill for empty configs Signed-off-by: SammyOina <sammyoina@gmail.com> * return nil for config file not found Signed-off-by: SammyOina <sammyoina@gmail.com> --------- Signed-off-by: SammyOina <sammyoina@gmail.com> Co-authored-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Which issue(s) does this PR fix/relate to?
None
List any changes that modify/break current functionality
None
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes