Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Check For Subject During Policy Addition #1826

Merged
merged 19 commits into from
Aug 2, 2023

Simplify checkSubject

ceeaa85
Select commit
Loading
Failed to load commit list.
Merged

NOISSUE - Check For Subject During Policy Addition #1826

Simplify checkSubject
ceeaa85
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 2, 2023 in 0s

67.40% (-0.04%) compared to 8c17841

View this Pull Request on Codecov

67.40% (-0.04%) compared to 8c17841

Details

Codecov Report

Merging #1826 (ceeaa85) into master (8c17841) will decrease coverage by 0.04%.
The diff coverage is 56.25%.

@@            Coverage Diff             @@
##           master    #1826      +/-   ##
==========================================
- Coverage   67.44%   67.40%   -0.04%     
==========================================
  Files         118      118              
  Lines        9470     9483      +13     
==========================================
+ Hits         6387     6392       +5     
- Misses       2404     2408       +4     
- Partials      679      683       +4     
Files Changed Coverage Δ
things/groups/service.go 74.57% <ø> (ø)
things/policies/policies.go 77.27% <ø> (ø)
users/groups/service.go 67.96% <ø> (ø)
things/clients/service.go 73.82% <50.00%> (ø)
users/clients/service.go 59.84% <50.00%> (ø)
things/policies/service.go 53.43% <55.55%> (-1.65%) ⬇️
users/policies/policies.go 88.63% <100.00%> (ø)
users/policies/service.go 65.06% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more