NOISSUE - Propagate Context #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1842 +/- ##
==========================================
- Coverage 65.69% 65.68% -0.01%
==========================================
Files 116 116
Lines 9415 9413 -2
==========================================
- Hits 6185 6183 -2
Misses 2572 2572
Partials 658 658
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dborovcanin
requested changes
Jul 6, 2023
cmd/users/main.go
Outdated
| return err | ||
| } | ||
| _, err = svc.IssueToken(context.Background(), c.AdminEmail, c.AdminPassword) | ||
| _, err = svc.IssueToken(ctx, c.AdminEmail, c.AdminPassword) |
dborovcanin
approved these changes
Jul 6, 2023
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
WashingtonKK
pushed a commit
to WashingtonKK/magistrala
that referenced
this pull request
Jul 7, 2023
* Initial Commit: Propagate Context Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Make IssueToken Inline Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Co-authored-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com> Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
WashingtonKK
pushed a commit
to WashingtonKK/magistrala
that referenced
this pull request
Jul 12, 2023
* Initial Commit: Propagate Context Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Make IssueToken Inline Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Co-authored-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com>
WashingtonKK
pushed a commit
to WashingtonKK/magistrala
that referenced
this pull request
Jul 12, 2023
* Initial Commit: Propagate Context Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Make IssueToken Inline Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Co-authored-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Propagate context throughout mainflux by trying to use
context.Backgroundas minimum as possibleWhich issue(s) does this PR fix/relate to?
No issue
List any changes that modify/break current functionality
No changes that modify the functionality of the system
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes
Should we add context to
readersandconsumers?