Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Remove Auth Service #1845

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Conversation

rodneyosodo
Copy link
Member

What does this do?

Removes auth services from prometheus and grafana dashboards as it was deprricated

Which issue(s) does this PR fix/relate to?

No issue

List any changes that modify/break current functionality

We had grafana dashboard for auth services which was reporting down since it is not there

Have you included tests for your changes?

No

Did you document any new/modified functionality?

No

Notes

image

@rodneyosodo rodneyosodo requested a review from a team as a code owner July 5, 2023 08:28
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #1845 (3fdac40) into master (723dc52) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1845   +/-   ##
=======================================
  Coverage   65.69%   65.69%           
=======================================
  Files         116      116           
  Lines        9415     9415           
=======================================
  Hits         6185     6185           
  Misses       2572     2572           
  Partials      658      658           
Impacted Files Coverage Δ
things/policies/auth.pb.go 11.36% <ø> (ø)
things/policies/auth_grpc.pb.go 0.00% <0.00%> (ø)
users/policies/auth.pb.go 4.47% <ø> (ø)
users/policies/auth_grpc.pb.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 60e9d17 into absmach:master Jul 6, 2023
WashingtonKK pushed a commit to WashingtonKK/magistrala that referenced this pull request Jul 7, 2023
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Co-authored-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
WashingtonKK pushed a commit to WashingtonKK/magistrala that referenced this pull request Jul 12, 2023
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Co-authored-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com>
WashingtonKK pushed a commit to WashingtonKK/magistrala that referenced this pull request Jul 12, 2023
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Co-authored-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants