Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Add deployments data collection banner #1854

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

SammyOina
Copy link
Contributor

What does this do?

Details data collected on call-home service and links to website and provides details to users.

Which issue(s) does this PR fix/relate to?

None

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

Notes

@SammyOina SammyOina requested a review from a team as a code owner July 7, 2023 12:20
dborovcanin
dborovcanin previously approved these changes Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #1854 (9619242) into master (106b710) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1854   +/-   ##
=======================================
  Coverage   64.73%   64.73%           
=======================================
  Files         118      118           
  Lines        9702     9702           
=======================================
  Hits         6281     6281           
  Misses       2753     2753           
  Partials      668      668           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
@drasko drasko merged commit 315c176 into absmach:master Jul 26, 2023
3 checks passed
WashingtonKK pushed a commit to WashingtonKK/magistrala that referenced this pull request Jul 28, 2023
* initial banner

Signed-off-by: SammyOina <sammyoina@gmail.com>

* add disabling

Signed-off-by: SammyOina <sammyoina@gmail.com>

* add approximate keyword

Signed-off-by: SammyOina <sammyoina@gmail.com>

---------

Signed-off-by: SammyOina <sammyoina@gmail.com>
WashingtonKK pushed a commit to WashingtonKK/magistrala that referenced this pull request Jul 28, 2023
* initial banner

Signed-off-by: SammyOina <sammyoina@gmail.com>

* add disabling

Signed-off-by: SammyOina <sammyoina@gmail.com>

* add approximate keyword

Signed-off-by: SammyOina <sammyoina@gmail.com>

---------

Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
WashingtonKK pushed a commit to WashingtonKK/magistrala that referenced this pull request Jul 28, 2023
* initial banner

Signed-off-by: SammyOina <sammyoina@gmail.com>

* add disabling

Signed-off-by: SammyOina <sammyoina@gmail.com>

* add approximate keyword

Signed-off-by: SammyOina <sammyoina@gmail.com>

---------

Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
rodneyosodo pushed a commit to rodneyosodo/magistrala that referenced this pull request Aug 3, 2023
* initial banner

Signed-off-by: SammyOina <sammyoina@gmail.com>

* add disabling

Signed-off-by: SammyOina <sammyoina@gmail.com>

* add approximate keyword

Signed-off-by: SammyOina <sammyoina@gmail.com>

---------

Signed-off-by: SammyOina <sammyoina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants