NOISSUE-Update invalid secret error handling #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodneyosodo
requested changes
Jul 11, 2023
ianmuchyri
force-pushed
the
NOISSUE-UpdateSecretErrorHandling
branch
from
f972baa
to
ba21556
Compare
dborovcanin
previously approved these changes
Jul 12, 2023
rodneyosodo
requested changes
Jul 12, 2023
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
dborovcanin
force-pushed
the
NOISSUE-UpdateSecretErrorHandling
branch
from
ba21556
to
d243075
Compare
drasko
requested changes
Jul 12, 2023
rodneyosodo
reviewed
Jul 12, 2023
Codecov Report
@@ Coverage Diff @@
## master #1856 +/- ##
==========================================
+ Coverage 64.12% 64.14% +0.02%
==========================================
Files 118 118
Lines 9642 9642
==========================================
+ Hits 6183 6185 +2
+ Misses 2801 2800 -1
+ Partials 658 657 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
rodneyosodo
requested changes
Jul 12, 2023
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
SammyOina
pushed a commit
to SammyOina/mainflux
that referenced
this pull request
Jul 13, 2023
* update invalid secret error handling Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * update secret error naming Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * update secretError naming Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * fix comment Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * add empty space in comment Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> --------- Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> Signed-off-by: SammyOina <sammyoina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Updates error handling to handle invalid secret
Which issue(s) does this PR fix/relate to?
Put here
Resolves #XXXto auto-close the issue that your PR fixes (if such)No issue
List any changes that modify/break current functionality
None
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes