NOISSUE - Enable OwnerID Filtering For Admin #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammyOina
requested changes
Jul 11, 2023
Codecov Report
@@ Coverage Diff @@
## master #1857 +/- ##
==========================================
+ Coverage 64.12% 64.65% +0.52%
==========================================
Files 118 118
Lines 9642 9678 +36
==========================================
+ Hits 6183 6257 +74
+ Misses 2801 2753 -48
- Partials 658 668 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rodneyosodo
force-pushed
the
NOISSUE-ownerIDfiltering
branch
from
6b2b558
to
83f6ca7
Compare
rodneyosodo
force-pushed
the
NOISSUE-ownerIDfiltering
branch
6 times, most recently
from
3693ef2
to
653c0f3
Compare
dborovcanin
force-pushed
the
NOISSUE-ownerIDfiltering
branch
from
653c0f3
to
2e7460e
Compare
rodneyosodo
force-pushed
the
NOISSUE-ownerIDfiltering
branch
from
2e7460e
to
7565094
Compare
dborovcanin
approved these changes
Jul 13, 2023
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Co-authored-by: Sammy Kerata Oina <44265300+SammyOina@users.noreply.github.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Co-authored-by: Sammy Kerata Oina <44265300+SammyOina@users.noreply.github.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Co-authored-by: Sammy Kerata Oina <44265300+SammyOina@users.noreply.github.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Co-authored-by: Sammy Kerata Oina <44265300+SammyOina@users.noreply.github.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
rodneyosodo
force-pushed
the
NOISSUE-ownerIDfiltering
branch
from
dd54f9d
to
c9db748
Compare
rodneyosodo
added a commit
to rodneyosodo/magistrala
that referenced
this pull request
Aug 3, 2023
* Enable OwnerID Filtering For Admin Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Update things/clients/service.go Co-authored-by: Sammy Kerata Oina <44265300+SammyOina@users.noreply.github.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Update things/clients/service.go Co-authored-by: Sammy Kerata Oina <44265300+SammyOina@users.noreply.github.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Update things/clients/service.go Co-authored-by: Sammy Kerata Oina <44265300+SammyOina@users.noreply.github.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Update things/clients/service.go Co-authored-by: Sammy Kerata Oina <44265300+SammyOina@users.noreply.github.com> Signed-off-by: rodneyosodo <blackd0t@protonmail.com> * Combine the Switch Statement Signed-off-by: rodneyosodo <blackd0t@protonmail.com> --------- Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Co-authored-by: Sammy Kerata Oina <44265300+SammyOina@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Enable filtering by
ownerIDwhen the client logged in is the adminWhich issue(s) does this PR fix/relate to?
No issue
List any changes that modify/break current functionality
disconnectedandsharedbytags on pagemineto"". This is now done at the service layerHave you included tests for your changes?
No
Did you document any new/modified functionality?
Yes
Notes
N/A