-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MF-1340 - Add CLI config TOML file #1858
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1858 +/- ##
=======================================
Coverage 67.43% 67.43%
=======================================
Files 118 118
Lines 9491 9491
=======================================
Hits 6400 6400
Misses 2409 2409
Partials 682 682 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@WashingtonKK please refer to the correct originating issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no support in the CLI for parsing most of the config parameters in this PR https://github.com/mainflux/mainflux/blob/aee0081864f9654f0eeb2c08a36ed5350ce04372/cli/config.go#L15-L20.
I also don't think this PR fully addresses the requirements in #1340
What do you recommend? Also, @dborovcanin , what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to put "flags" and "flags.root", you can use "urls" for root URLs. The same goes for "flags.channels" and "flags.client" - "channel"
and "client"
are sufficient. Also, rename client
to filter
or something similar. Once that's done, you need to add the actual parsing and set the CLI config values from this file, like @SammyOina mentioned here.
Addressed in PR review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all cases utilizing the fmt and log package to output text use the mainflux logger package instead
@WashingtonKK , Configurations in |
@arvindh123 , I have fixed this |
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this since it is created automatically anyway when you run the CLI.
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull request title should be
MF-XXX - description
orNOISSUE - description
where XXX is ID of issue that this PR relate to.Please review the CONTRIBUTING.md file for detailed contributing guidelines.
What does this do?
Creates a TOML file for CLI
Which issue(s) does this PR fix/relate to?
#1340
List any changes that modify/break current functionality
N/A
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes