Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Add List Actions #1861

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

rodneyosodo
Copy link
Member

What does this do?

When adding actions additionally add listing action
c_ includes c_list and g_list
g_ includes g_list

Which issue(s) does this PR fix/relate to?

No issue

List any changes that modify/break current functionality

Add list actions together with other actions if not provided

Have you included tests for your changes?

Yes

Did you document any new/modified functionality?

No

Notes

Steps to reproduce this

  1. Create 2 users a and b and group a
  2. Add users a and b to that group with the c_update action
  3. List users with user a token with visibility option set as shared.

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
@rodneyosodo rodneyosodo requested a review from a team as a code owner July 18, 2023 09:41
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #1861 (9e90407) into master (726e358) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1861      +/-   ##
==========================================
- Coverage   64.74%   64.73%   -0.01%     
==========================================
  Files         118      118              
  Lines        9646     9702      +56     
==========================================
+ Hits         6245     6281      +36     
- Misses       2733     2753      +20     
  Partials      668      668              
Impacted Files Coverage Δ
users/clients/service.go 59.84% <45.45%> (-2.71%) ⬇️
things/groups/postgres/groups.go 68.88% <50.00%> (-0.29%) ⬇️
things/groups/service.go 74.57% <50.00%> (+0.40%) ⬆️
users/groups/postgres/groups.go 68.97% <50.00%> (-0.29%) ⬇️
things/clients/service.go 73.82% <59.09%> (-0.90%) ⬇️
users/policies/policies.go 100.00% <100.00%> (ø)
users/policies/service.go 63.75% <100.00%> (+0.45%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

users/policies/policies.go Show resolved Hide resolved
users/policies/policies.go Show resolved Hide resolved
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 41be96a into absmach:master Jul 18, 2023
WashingtonKK pushed a commit to WashingtonKK/magistrala that referenced this pull request Jul 24, 2023
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
WashingtonKK pushed a commit to WashingtonKK/magistrala that referenced this pull request Jul 27, 2023
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
rodneyosodo added a commit to rodneyosodo/magistrala that referenced this pull request Aug 3, 2023
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants