NOISSUE-Update initialization of instanceID #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
rodneyosodo
requested changes
Aug 1, 2023
Codecov Report
@@ Coverage Diff @@
## master #1873 +/- ##
=======================================
Coverage 67.53% 67.53%
=======================================
Files 118 118
Lines 9457 9457
=======================================
Hits 6387 6387
Misses 2395 2395
Partials 675 675
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
rodneyosodo
requested changes
Aug 1, 2023
There was a problem hiding this comment.
Also rename this https://github.com/ianmuchyri/mainflux/blob/e92ca98508dae7eb65da4fa0a09da8b54e06933f/internal/clients/jaeger/provider.go#L41 as depicted by opentelemetry quidelines https://github.com/open-telemetry/semantic-conventions/blob/main/docs/resource/host.md
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
rodneyosodo
pushed a commit
to rodneyosodo/magistrala
that referenced
this pull request
Aug 3, 2023
* update initialization of instanceID Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * remove capital letter in error log Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * rename instanceID to host.id Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * remove previous fix Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> --------- Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> Co-authored-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com>
WashingtonKK
pushed a commit
to WashingtonKK/magistrala
that referenced
this pull request
Aug 4, 2023
* update initialization of instanceID Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * remove capital letter in error log Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * rename instanceID to host.id Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * remove previous fix Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> --------- Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> Co-authored-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
removes unnecessary
instanceIDinitialization and instead usescfg.InstanceIDdirectly.Which issue(s) does this PR fix/relate to?
List any changes that modify/break current functionality
none
Have you included tests for your changes?
no
Did you document any new/modified functionality?
no
Notes