Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Add linter config file and add duplicate import check #1880

Merged
merged 4 commits into from
Aug 10, 2023

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Aug 8, 2023

What does this do?

  • Use config file for linter
  • Add checks for duplicate imports using gocritic
    image

Which issue(s) does this PR fix/relate to?

improves on https://github.com/mainflux/mainflux/issues/1774

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

Notes

https://github.com/go-critic/go-critic
https://golangci-lint.run/usage/configuration/

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1880 (a9403a6) into master (5e85554) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1880   +/-   ##
=======================================
  Coverage   67.16%   67.16%           
=======================================
  Files         118      118           
  Lines        9076     9076           
=======================================
  Hits         6096     6096           
  Misses       2351     2351           
  Partials      629      629           
Files Changed Coverage Δ
bootstrap/api/transport.go 94.70% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SammyOina SammyOina marked this pull request as ready for review August 8, 2023 07:29
@SammyOina SammyOina requested a review from a team as a code owner August 8, 2023 07:29
scripts/ci.sh Show resolved Hide resolved
@SammyOina SammyOina changed the title NOISSUE - Add duplicate import check NOISSUE - Add linter config file and add duplicate import check Aug 8, 2023
@SammyOina SammyOina marked this pull request as draft August 8, 2023 08:43
@SammyOina SammyOina force-pushed the lint-additions branch 2 times, most recently from 3297a1e to a7b1768 Compare August 9, 2023 11:34
@SammyOina SammyOina marked this pull request as ready for review August 9, 2023 12:39
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Copy link
Collaborator

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI.

Signed-off-by: SammyOina <sammyoina@gmail.com>
Copy link
Member

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 91e3873 into absmach:master Aug 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants