Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Remove Secret on Viewing User(s) and Things #1884

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

rodneyosodo
Copy link
Member

Signed-off-by: rodneyosodo blackd0t@protonmail.com

What does this do?

  • Redact the user's secret on viewing a user or listing users.
  • Redact the things's secret on viewing a thing or listing things

Which issue(s) does this PR fix/relate to?

No issue

List any changes that modify/break current functionality

Secret will be empty on listing users/things

Have you included tests for your changes?

Yes

Did you document any new/modified functionality?

Yes

Notes

Mentioned here ultravioletrs/cocos-docs#9 (comment)

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1884 (e327f0a) into master (b4b625d) will decrease coverage by 0.02%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##           master    #1884      +/-   ##
==========================================
- Coverage   67.12%   67.11%   -0.02%     
==========================================
  Files         118      118              
  Lines        9011     9019       +8     
==========================================
+ Hits         6049     6053       +4     
- Misses       2333     2337       +4     
  Partials      629      629              
Files Changed Coverage Δ
users/clients/service.go 60.14% <50.00%> (-0.31%) ⬇️
pkg/clients/postgres/clients.go 79.06% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 896a74a into absmach:master Aug 9, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants