Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Enable JetStream on NATS #1885

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

rodneyosodo
Copy link
Member

Signed-off-by: rodneyosodo blackd0t@protonmail.com

What does this do?

Enables jestream on nats

Which issue(s) does this PR fix/relate to?

No issue

List any changes that modify/break current functionality

None

Have you included tests for your changes?

Manually tested

Did you document any new/modified functionality?

No

Notes

This is the first of many PRs to move from Redis for streaming to Nats

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1885 (b8e70ae) into master (5fa2bf4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1885   +/-   ##
=======================================
  Coverage   66.94%   66.94%           
=======================================
  Files         118      118           
  Lines        9080     9080           
=======================================
  Hits         6079     6079           
  Misses       2372     2372           
  Partials      629      629           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rodneyosodo rodneyosodo marked this pull request as ready for review August 23, 2023 10:58
@rodneyosodo rodneyosodo requested a review from a team as a code owner August 23, 2023 10:58
@dborovcanin dborovcanin changed the title NOISSUE - Enable Jestream on Nats NOISSUE - Enable Jestream on NATS Aug 23, 2023
Copy link
Contributor

@SammyOina SammyOina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo on title Jestream -> JetStream

@rodneyosodo rodneyosodo changed the title NOISSUE - Enable Jestream on NATS NOISSUE - Enable JetStream on NATS Aug 23, 2023
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
@drasko drasko merged commit 2252438 into absmach:master Aug 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants