NOISSUE - Fix Share Thing To Add External To Request #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1886 +/- ##
==========================================
- Coverage 67.12% 67.11% -0.02%
==========================================
Files 118 118
Lines 9011 9020 +9
==========================================
+ Hits 6049 6054 +5
- Misses 2333 2337 +4
Partials 629 629
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
rodneyosodo
force-pushed
the
NOISSUE-sharething
branch
from
93a3962
to
6bcdd4f
Compare
drasko
requested changes
Aug 8, 2023
pkg/sdk/go/policies.go
Outdated
| @@ -21,6 +21,7 @@ type Policy struct { | |||
| Subject string `json:"subject"` | |||
| Object string `json:"object"` | |||
| Actions []string `json:"actions"` | |||
| External bool `json:"external,omitempty"` | |||
There was a problem hiding this comment.
There probably should be a comment explaining what this External means, as here it looks like it means something like "external policy"
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
dborovcanin
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rodneyosodo blackd0t@protonmail.com
What does this do?
Enables sharing things on SDK level
Which issue(s) does this PR fix/relate to?
No issue
List any changes that modify/break current functionality
None
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes
Add
externalfield to policies. This will enables us to share things between users