Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Convert Docker Project Name to Lowercase #1894

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

rodneyosodo
Copy link
Member

What does this do?

Converts docker project name to lowercase in case the branch is in uppercase since most of our branches are MF- which is uppercase

Which issue(s) does this PR fix/relate to?

No issue

List any changes that modify/break current functionality

None

Have you included tests for your changes?

Yes
image

Did you document any new/modified functionality?

No

Notes

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
@rodneyosodo rodneyosodo requested a review from a team as a code owner August 23, 2023 09:17
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #1894 (45bf35d) into master (0525a9a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1894   +/-   ##
=======================================
  Coverage   67.15%   67.15%           
=======================================
  Files         118      118           
  Lines        9074     9074           
=======================================
  Hits         6094     6094           
  Misses       2351     2351           
  Partials      629      629           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 20e8593 into absmach:master Aug 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants