NOISSUE - Refactor Redis URI #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodneyosodo
force-pushed
the
noissue-seperate-cache
branch
from
ca41ec8
to
ed96000
Compare
rodneyosodo
force-pushed
the
noissue-seperate-cache
branch
from
ed96000
to
2820ace
Compare
Codecov Report
@@ Coverage Diff @@
## master #1898 +/- ##
==========================================
+ Coverage 67.14% 67.25% +0.11%
==========================================
Files 120 126 +6
Lines 9145 9436 +291
==========================================
+ Hits 6140 6346 +206
- Misses 2368 2431 +63
- Partials 637 659 +22
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rodneyosodo
force-pushed
the
noissue-seperate-cache
branch
from
995910f
to
e458830
Compare
rodneyosodo
force-pushed
the
noissue-seperate-cache
branch
2 times, most recently
from
e215cf6
to
a84bb0d
Compare
rodneyosodo
force-pushed
the
noissue-seperate-cache
branch
3 times, most recently
from
a9e483d
to
9ad7df1
Compare
Signed-off-by: rodneyosodo <blackd0t@protonmail.com> Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Use a single Redis URI to connect to Redis where the URI contains host, port, database and possibly username and password. This is to simplify environment variable configuration. Signed-off-by: Rodney Osodo <socials@rodneyosodo.com> Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>
dborovcanin
force-pushed
the
noissue-seperate-cache
branch
from
9ad7df1
to
71c6711
Compare
dborovcanin
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rodney Osodo socials@rodneyosodo.com
What does this do?
Use one environment variable which is redis URI to get information about the username, password, host, port and database rather than separate environment variables
Which issue(s) does this PR fix/relate to?
No issue
List any changes that modify/break current functionality
None - Move from 3 config variables for redis to one
Have you included tests for your changes?
No
Did you document any new/modified functionality?
Yes
Notes
N/A