Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix WS Adapter Messaging #1899

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

rodneyosodo
Copy link
Member

What does this do?

Fixes ws adapter communication

Which issue(s) does this PR fix/relate to?

No issue

List any changes that modify/break current functionality

  • use context from main on ws handshake rather than request.Context() as it closed once the function returns
  • Remove unsubscribe after publishing message.
  • Authorize ws with Read and Write Actions respectively

Have you included tests for your changes?

No

Did you document any new/modified functionality?

No

Notes

N/A

Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #1899 (6a3a518) into master (320921a) will increase coverage by 0.01%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##           master    #1899      +/-   ##
==========================================
+ Coverage   66.94%   66.96%   +0.01%     
==========================================
  Files         118      118              
  Lines        9080     9078       -2     
==========================================
  Hits         6079     6079              
+ Misses       2372     2370       -2     
  Partials      629      629              
Files Changed Coverage Δ
mqtt/handler.go 92.00% <50.00%> (ø)
ws/adapter.go 87.75% <100.00%> (ø)
ws/api/endpoints.go 78.26% <100.00%> (+1.66%) ⬆️
ws/api/transport.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rodneyosodo rodneyosodo marked this pull request as ready for review August 30, 2023 09:46
@rodneyosodo rodneyosodo requested a review from a team as a code owner August 30, 2023 09:46
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 7c3add6 into absmach:master Sep 1, 2023
3 checks passed
@rodneyosodo rodneyosodo deleted the noissue-fix-ws branch October 22, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants