Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF-1913 - modify docker-compose of postgres-reader #1914

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

ahmmkh
Copy link
Contributor

@ahmmkh ahmmkh commented Oct 4, 2023

What does this do?

Edit docker-compose of Postgres reader to set an environment variable that indicates the DB name.

Which issue(s) does this PR fix/relate to?

Put here Resolves #XXX to auto-close the issue that your PR fixes (if such)
Fixes #1913.

List any changes that modify/break current functionality

N/A

Have you included tests for your changes?

N/A

Did you document any new/modified functionality?

No.

Notes

N/A

@ahmmkh ahmmkh requested a review from a team as a code owner October 4, 2023 18:11
@ahmmkh ahmmkh changed the title MF-1913 - modify docker-compose of postgres reader MF-1913 - modify docker-compose of postgres-reader Oct 4, 2023
Signed-off-by: Ahmed Khatab <a@khatab.me>

 Changes to be committed:
	modified:   docker/addons/postgres-reader/docker-compose.yml

Signed-off-by: Khatab <a@khatab.me>
Copy link
Contributor

@arvindh123 arvindh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 59bcb72 into absmach:master Oct 5, 2023
1 of 2 checks passed
@drasko
Copy link
Contributor

drasko commented Oct 5, 2023

Merged! Thanks @ahmmkh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres reader is not working properly
4 participants