NOISSUE: Listing of shared things with users & Update SDK #1923

arvindh123 · 2023-10-16T08:09:13Z

Pull request title should be MF-XXX - description or NOISSUE - description where XXX is ID of issue that this PR relate to.
Please review the CONTRIBUTING.md file for detailed contributing guidelines.

What does this do?

Provides endpoint and service functions to list shared things with users
Update SDK
Update CLI
Add signature to previous commits

Which issue(s) does this PR fix/relate to?

Put here Resolves #XXX to auto-close the issue that your PR fixes (if such)

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

Notes

* fix bugs Signed-off-by: Arvindh <arvindh91@gmail.com> * fix bugs Signed-off-by: Arvindh <arvindh91@gmail.com> --------- Signed-off-by: Arvindh <arvindh91@gmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>

* fix bugs Signed-off-by: Arvindh <arvindh91@gmail.com> * fix bugs Signed-off-by: Arvindh <arvindh91@gmail.com> * fix list of things in a channel and Add connect disconnect endpoint Signed-off-by: Arvindh <arvindh91@gmail.com> * fix list of things in a channel and Add connect disconnect endpoint Signed-off-by: Arvindh <arvindh91@gmail.com> --------- Signed-off-by: Arvindh <arvindh91@gmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>

* fix list of things in a channel and Add connect disconnect endpoint Signed-off-by: Arvindh <arvindh91@gmail.com> * add: things share with other users Signed-off-by: Arvindh <arvindh91@gmail.com> --------- Signed-off-by: Arvindh <arvindh91@gmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>

* add: listing of channels, users, groups, things Signed-off-by: Arvindh <arvindh91@gmail.com> * add: listing of channels, users, groups, things Signed-off-by: Arvindh <arvindh91@gmail.com> * add: listing of channels, users, groups, things Signed-off-by: Arvindh <arvindh91@gmail.com> * add: listing of channels, users, groups, things Signed-off-by: Arvindh <arvindh91@gmail.com> --------- Signed-off-by: Arvindh <arvindh91@gmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>

* removed repeating code in list groups Signed-off-by: Arvindh <arvindh91@gmail.com> * add: list of user group Signed-off-by: Arvindh <arvindh91@gmail.com> * fix: otel handler operator name for endpoints Signed-off-by: Arvindh <arvindh91@gmail.com> --------- Signed-off-by: Arvindh <arvindh91@gmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>

Signed-off-by: Arvindh <arvindh91@gmail.com>

drasko · 2023-10-16T10:30:26Z

users/api/endpoints.go

+func listMembersByChannelEndpoint(svc users.Service) endpoint.Endpoint {
+	return func(ctx context.Context, request interface{}) (interface{}, error) {
+		req := request.(listMembersByObjectReq)
+		// in spiceDB channel is group kind


Start comment with a capital letter. Also, capitalize SpiceDB. What s "group kind" - is kind some tem from SpiceDB?

We not having any separate type for channel in spiceDB schema, Instead we using group type for storing channel relations.
Here the function name is listMembersByChannelEndpoint , which does listing of users in a channel
This function request we are passing req.objectKind = "groups" ,

This function is related to channels, then Why we here passing groups instead of channels ? Like this kind of question will raise when someone see the code.
Answer is same as said in the first, We are not having separate type for channel in spiceDB schema, Instead we using same group type for channel.

updated comment

Signed-off-by: Arvindh <arvindh91@gmail.com>

… spiceDB

dborovcanin · 2023-10-16T11:20:45Z

pkg/sdk/go/groups.go

+	return sdkerr
+}
+
+func (sdk mfSDK) RemoveUsersToGroup(groupID string, req UsersRelationRequest, token string) errors.SDKError {


RemoveUserFromGroup

Changed in all instance

dborovcanin · 2023-10-16T11:21:00Z

pkg/sdk/go/groups.go

@@ -164,6 +145,64 @@ func (sdk mfSDK) DisableGroup(id, token string) (Group, errors.SDKError) {
 	return sdk.changeGroupStatus(id, disableEndpoint, token)
 }

+func (sdk mfSDK) AddUsersToGroup(groupID string, req UsersRelationRequest, token string) errors.SDKError {


AddUserToGroup (a single user)

Changed in all instance

Signed-off-by: Arvindh <arvindh91@gmail.com>

…iceDB

Signed-off-by: Arvindh <arvindh91@gmail.com>

dborovcanin · 2023-10-17T09:36:47Z

internal/groups/service.go

@@ -217,7 +217,9 @@ func (svc service) ListGroups(ctx context.Context, token string, memberKind, mem
 	}

 	if len(ids) <= 0 {
-		return groups.Page{}, errors.ErrNotFound
+		return groups.Page{


Why do we even consider less than 0 for IDs length (i.e. why not if len(ids) == 0)?

Since len() returns int

dborovcanin · 2023-10-17T09:37:31Z

things/service.go

+		}
+	}
+
+	if len(ids) <= 0 {


The same here.

Since len() returns int

Signed-off-by: Arvindh <arvindh91@gmail.com>

drasko

LGTM

arvindh123 force-pushed the spiceDB branch from fcc7412 to 0442a45 Compare October 16, 2023 08:46

arvindh123 changed the title ~~NOISSUE: Listing of shared things with users~~ NOISSUE: Listing of shared things with users & Updating SDK Oct 16, 2023

arvindh123 marked this pull request as ready for review October 16, 2023 10:03

arvindh123 requested a review from a team as a code owner October 16, 2023 10:03

arvindh123 changed the title ~~NOISSUE: Listing of shared things with users & Updating SDK~~ NOISSUE: Listing of shared things with users & Update SDK Oct 16, 2023

arvindh123 and others added 9 commits October 16, 2023 15:37

NOISSUE - Fix Bugs (absmach#20)

05029d8

* fix bugs Signed-off-by: Arvindh <arvindh91@gmail.com> * fix bugs Signed-off-by: Arvindh <arvindh91@gmail.com> --------- Signed-off-by: Arvindh <arvindh91@gmail.com> Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>

add: listing of shared things and users

ac8e143

Signed-off-by: Arvindh <arvindh91@gmail.com>

fix: listing of shared things and users

0d674f4

Signed-off-by: Arvindh <arvindh91@gmail.com>

add: new SDK

91603a0

Signed-off-by: Arvindh <arvindh91@gmail.com>

add: new SDK

26c4550

Signed-off-by: Arvindh <arvindh91@gmail.com>

arvindh123 force-pushed the spiceDB branch from 2fdb6d8 to 26c4550 Compare October 16, 2023 10:12

drasko requested changes Oct 16, 2023

View reviewed changes

arvindh123 and others added 3 commits October 16, 2023 16:25

Merge branch 'master' into spiceDB

f1c8e93

fix: comment

7de6879

Signed-off-by: Arvindh <arvindh91@gmail.com>

Merge branch 'spiceDB' of https://github.com/arvindh123/mainflux into…

e8af120

… spiceDB

dborovcanin requested changes Oct 16, 2023

View reviewed changes

arvindh123 added 2 commits October 16, 2023 17:05

fix: sdk function names

35c7a59

Signed-off-by: Arvindh <arvindh91@gmail.com>

Merge branch 'master' of https://github.com/mainflux/mainflux into sp…

b07eac8

…iceDB

dborovcanin previously approved these changes Oct 16, 2023

View reviewed changes

update: api spec

a202c25

Signed-off-by: Arvindh <arvindh91@gmail.com>

arvindh123 dismissed dborovcanin’s stale review via a202c25 October 16, 2023 13:29

dborovcanin previously approved these changes Oct 16, 2023

View reviewed changes

fix: channels connect request

03bc3a9

Signed-off-by: Arvindh <arvindh91@gmail.com>

arvindh123 dismissed dborovcanin’s stale review via 03bc3a9 October 16, 2023 15:11

fix: listing of clients and groups

3d8a097

Signed-off-by: Arvindh <arvindh91@gmail.com>

dborovcanin requested changes Oct 17, 2023

View reviewed changes

arvindh123 and others added 3 commits October 17, 2023 15:29

fix: CLI

571fdaf

Signed-off-by: Arvindh <arvindh91@gmail.com>

fix: array len comparision

f9b8377

Signed-off-by: Arvindh <arvindh91@gmail.com>

Merge branch 'master' into spiceDB

3174355

dborovcanin previously approved these changes Oct 17, 2023

View reviewed changes

fix: nginx

33dbdab

Signed-off-by: Arvindh <arvindh91@gmail.com>

arvindh123 dismissed dborovcanin’s stale review via 33dbdab October 17, 2023 13:20

drasko approved these changes Oct 17, 2023

View reviewed changes

drasko merged commit cd82cc5 into absmach:master Oct 17, 2023
1 of 2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NOISSUE: Listing of shared things with users & Update SDK #1923

NOISSUE: Listing of shared things with users & Update SDK #1923

arvindh123 commented Oct 16, 2023 •

edited

Loading

drasko Oct 16, 2023

arvindh123 Oct 16, 2023

arvindh123 Oct 16, 2023

dborovcanin Oct 16, 2023

arvindh123 Oct 16, 2023

dborovcanin Oct 16, 2023 •

edited

Loading

arvindh123 Oct 16, 2023

dborovcanin Oct 17, 2023

arvindh123 Oct 17, 2023

dborovcanin Oct 17, 2023

arvindh123 Oct 17, 2023

drasko left a comment

NOISSUE: Listing of shared things with users & Update SDK #1923

NOISSUE: Listing of shared things with users & Update SDK #1923

Conversation

arvindh123 commented Oct 16, 2023 • edited Loading

What does this do?

Which issue(s) does this PR fix/relate to?

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

Notes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dborovcanin Oct 16, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

drasko left a comment

Choose a reason for hiding this comment

arvindh123 commented Oct 16, 2023 •

edited

Loading

dborovcanin Oct 16, 2023 •

edited

Loading