Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Update Go Version on Docker and CI #1925

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

rodneyosodo
Copy link
Member

Signed-off-by: Rodney Osodo 28790446+rodneyosodo@users.noreply.github.com

What does this do?

Updates go version on semaphore CI and docker images

Which issue(s) does this PR fix/relate to?

No issue. There was a breaking change when you tried to build images using docker with make dockers command. This fixes it.

List any changes that modify/break current functionality

None

Have you included tests for your changes?

Tested docker build manually

Did you document any new/modified functionality?

No

Notes

N/A

@rodneyosodo rodneyosodo requested a review from a team as a code owner October 16, 2023 09:39
The Dockerfile has been updated to use the latest version of the base image, golang:1.21-alpine, instead of golang:1.19-alpine. This update ensures that the application is built using the most recent version of the Go programming language.

Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>
The Go version in the Semaphore configuration file was updated from 1.20 to 1.21.

Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 6726bc7 into absmach:master Oct 16, 2023
1 of 2 checks passed
@rodneyosodo rodneyosodo deleted the goupdate branch October 22, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants