Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix Things Tests #1932

Merged
merged 1 commit into from
Oct 21, 2023
Merged

NOISSUE - Fix Things Tests #1932

merged 1 commit into from
Oct 21, 2023

Conversation

rodneyosodo
Copy link
Member

Signed-off-by: Rodney Osodo 28790446+rodneyosodo@users.noreply.github.com

What does this do?

  • Fix tests in things package to ensure they pass

Which issue(s) does this PR fix/relate to?

No issue

List any changes that modify/break current functionality

None

Have you included tests for your changes?

Yes

Did you document any new/modified functionality?

No

Notes

To be merged after https://github.com/mainflux/mainflux/pull/1931

Remove the unused variable inValidToken from the things/service_test.go file.

Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>
@rodneyosodo rodneyosodo marked this pull request as ready for review October 21, 2023 13:49
@rodneyosodo rodneyosodo requested a review from a team as a code owner October 21, 2023 13:49
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit fa00c82 into absmach:master Oct 21, 2023
1 of 2 checks passed
@rodneyosodo rodneyosodo deleted the things-test branch October 22, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants