Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF-378 - Add nginx ingress config to k8s services #472

Merged
merged 2 commits into from
Nov 27, 2018

Conversation

anovakovic01
Copy link
Contributor

What does this do?

Adds nginx ingress and istio setup to k8s setup. Also added automatic rescaling.

Which issue(s) does this PR fix/relate to?

This PR resolves #378, #387 and #390.

List any changes that modify/break current functionality

Added prefixes to k8s services.

Have you included tests for your changes?

No.

Did you document any new/modified functionality?

Updated README file for k8s setup.

drasko
drasko previously approved these changes Nov 26, 2018
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Nov 27, 2018

Codecov Report

Merging #472 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #472   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files          54       54           
  Lines        2372     2372           
=======================================
  Hits         2076     2076           
  Misses        194      194           
  Partials      102      102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cd1153...004d410. Read the comment docs.

Update README in accordance to latest changes. Add gRPC load
balancing setup. Add healthcheck to k8s setup.

Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
@chombium
Copy link
Collaborator

LGTM

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 59c5e35 into absmach:master Nov 27, 2018
anovakovic01 added a commit to anovakovic01/mainflux that referenced this pull request Nov 27, 2018
Update README in accordance to latest changes. Add gRPC load
balancing setup. Add healthcheck to k8s setup.

Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
davide83 pushed a commit to davide83/mainflux that referenced this pull request May 13, 2019
Update README in accordance to latest changes. Add gRPC load
balancing setup. Add healthcheck to k8s setup.

Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
manuio pushed a commit that referenced this pull request Oct 12, 2020
Update README in accordance to latest changes. Add gRPC load
balancing setup. Add healthcheck to k8s setup.

Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to ingress nginx on k8s setup
4 participants