Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOISSUE - Add LoRa route map validation and fix LoRa messages URL #491

Merged
merged 7 commits into from
Dec 5, 2018
Merged

NOISSUE - Add LoRa route map validation and fix LoRa messages URL #491

merged 7 commits into from
Dec 5, 2018

Conversation

manuio
Copy link
Contributor

@manuio manuio commented Dec 5, 2018

No description provided.

@manuio
Add route map validation and fix LoRa messages URL
c7027cf 
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
@codecov-io
Copy link

codecov-io commented Dec 5, 2018 •
edited
Loading

Codecov Report

Merging #491 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #491      +/-   ##
==========================================
+ Coverage   87.85%   87.93%   +0.08%     
==========================================
  Files          53       53              
  Lines        2371     2371              
==========================================
+ Hits         2083     2085       +2     
+ Misses        191      189       -2     
  Partials       97       97
Impacted Files Coverage Δ
things/service.go 93.57% <0%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9bf63e...0d615ad. Read the comment docs.

anovakovic01
anovakovic01 suggested changes Dec 5, 2018
View reviewed changes
lora/redis/streams.go Outdated
@@ -170,6 +170,9 @@ func (es eventStore) handleUpdateThing(ute updateThingEvent) error {
if em.Type != protocol {
return errors.New("Lora protocol not found in thing metadatada")
}
if em.DevEUI != "" {
return errors.New("Lora device EUI not found in thing metadatada")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move these errors to var block at the beginning of the file.

@manuio
Fix reviews
3cbd241 
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
drasko
drasko previously approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko dismissed their stale review December 5, 2018 11:42

Missed one thing for MQTT

drasko
drasko previously approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuio
Merge branch 'master' of https://github.com/mainflux/mainflux
af7c580
@manuio
Fix reviews
add27a3 
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
@manuio
Rm private error comments
4dfb03f 
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
anovakovic01
anovakovic01 previously approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@anovakovic01 anovakovic01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manuio
Fix typo
614125a 
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
anovakovic01
anovakovic01 previously approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@anovakovic01 anovakovic01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

drasko
drasko previously approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuio
Add runlora command in Makefile
0d615ad 
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
@manuio manuio dismissed stale reviews from drasko and anovakovic01 via 0d615ad December 5, 2018 14:08
@drasko drasko merged commit 715a662 into absmach:master Dec 5, 2018
juanmagal pushed a commit to juanmagal/mainflux that referenced this pull request Feb 5, 2019
@manuio @juanmagal
NOISSUE - Add LoRa route map validation and fix LoRa messages URL (ab…
95b4b69 
…smach#491)

* Add route map validation and fix LoRa messages URL

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix reviews

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix reviews

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Rm private error comments

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix typo

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Add runlora command in Makefile

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
davide83 pushed a commit to davide83/mainflux that referenced this pull request May 13, 2019
@manuio @davide83
NOISSUE - Add LoRa route map validation and fix LoRa messages URL (ab…
b434f8c 
…smach#491)

* Add route map validation and fix LoRa messages URL

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix reviews

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix reviews

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Rm private error comments

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix typo

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Add runlora command in Makefile

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
manuio added a commit that referenced this pull request Oct 12, 2020
@manuio @drasko
NOISSUE - Add LoRa route map validation and fix LoRa messages URL (#491)
630e115 
* Add route map validation and fix LoRa messages URL

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix reviews

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix reviews

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Rm private error comments

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Fix typo

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Add runlora command in Makefile

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drasko drasko drasko left review comments

@anovakovic01 anovakovic01 anovakovic01 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manuio @codecov-io @drasko @anovakovic01