Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Refine docs #537

Merged
merged 1 commit into from
Jan 9, 2019
Merged

NOISSUE - Refine docs #537

merged 1 commit into from
Jan 9, 2019

Conversation

drasko
Copy link
Contributor

@drasko drasko commented Jan 8, 2019

Signed-off-by: drasko drasko.draskovic@gmail.com

What does this do?

Breaks long Getting Started into separate dedicated chapters. Uses CLI for Getting Started example for simplicity.

manuio
manuio previously approved these changes Jan 9, 2019
Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/getting-started.md Outdated Show resolved Hide resolved
docs/getting-started.md Show resolved Hide resolved
docs/getting-started.md Show resolved Hide resolved
docs/getting-started.md Outdated Show resolved Hide resolved
docs/lora.md Outdated Show resolved Hide resolved
Signed-off-by: drasko <drasko.draskovic@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #537 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #537   +/-   ##
=======================================
  Coverage   87.35%   87.35%           
=======================================
  Files          62       62           
  Lines        3297     3297           
=======================================
  Hits         2880     2880           
  Misses        286      286           
  Partials      131      131

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c788ef6...8779779. Read the comment docs.

Copy link
Contributor

@anovakovic01 anovakovic01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anovakovic01 anovakovic01 merged commit 3bbd21f into absmach:master Jan 9, 2019
@drasko drasko deleted the docs branch February 2, 2019 00:42
juanmagal pushed a commit to juanmagal/mainflux that referenced this pull request Feb 5, 2019
Signed-off-by: drasko <drasko.draskovic@gmail.com>
davide83 pushed a commit to davide83/mainflux that referenced this pull request May 13, 2019
Signed-off-by: drasko <drasko.draskovic@gmail.com>
manuio pushed a commit that referenced this pull request Oct 12, 2020
Signed-off-by: drasko <drasko.draskovic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants