Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF-370 - Simplify and refine CI #541

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Conversation

dborovcanin
Copy link
Collaborator

@dborovcanin dborovcanin commented Jan 10, 2019

Signed-off-by: Dusan Borovcanin dusan.borovcanin@mainflux.com.

What does this do?

This pull request adds a script to be executed by a CI tool.

Which issue(s) does this PR fix/relate to?

This pull request closes #370.

chombium
chombium previously approved these changes Jan 10, 2019
- go get -d github.com/mainflux/mainflux
- cd $GOPATH/src/github.com/mainflux/mainflux
- make proto
- set -e; echo "" > coverage.txt; for d in $(go list ./... | grep -v 'vendor\|cmd'); do GOCACHE=off go test -v -race -tags test -coverprofile=profile.out -covermode=atomic $d; if [ -f profile.out ]; then cat profile.out >> coverage.txt; rm profile.out; fi done
Copy link
Collaborator

@chombium chombium Jan 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest use of multiline string (Block Scalar >) as described here for better visibility, but I'm not sure if it will work with Semaphore CI. Other than that all looks good to me, but Semaphore CI does not report a status... I guess something else should be adjusted as well. Do we have any logs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chombium We've decided not to switch to Semaphore 2 yet because it's still in Beta phase. This PR will add simple shell script that will be executed by Semaphore so that we can track CI commands changes.

Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
@codecov-io
Copy link

codecov-io commented Jan 11, 2019

Codecov Report

Merging #541 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage   87.17%   87.35%   +0.18%     
==========================================
  Files          62       62              
  Lines        3297     3297              
==========================================
+ Hits         2874     2880       +6     
+ Misses        291      286       -5     
+ Partials      132      131       -1
Impacted Files Coverage Δ
ws/api/transport.go 87.05% <0%> (+7.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0505e0...1bc394d. Read the comment docs.

Add script explanation comment.

Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmarcetic nmarcetic merged commit 7ff7383 into absmach:master Jan 11, 2019
@dborovcanin dborovcanin deleted the MF-370 branch January 31, 2019 10:51
juanmagal pushed a commit to juanmagal/mainflux that referenced this pull request Feb 5, 2019
* Add CI script

Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>

* Fix indentetion

Add script explanation comment.

Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
davide83 pushed a commit to davide83/mainflux that referenced this pull request May 13, 2019
* Add CI script

Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>

* Fix indentetion

Add script explanation comment.

Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
manuio pushed a commit that referenced this pull request Oct 12, 2020
* Add CI script

Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>

* Fix indentetion

Add script explanation comment.

Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify and refine CI
5 participants