-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MF-370 - Simplify and refine CI #541
Conversation
.semaphore/semaphore.yml
Outdated
- go get -d github.com/mainflux/mainflux | ||
- cd $GOPATH/src/github.com/mainflux/mainflux | ||
- make proto | ||
- set -e; echo "" > coverage.txt; for d in $(go list ./... | grep -v 'vendor\|cmd'); do GOCACHE=off go test -v -race -tags test -coverprofile=profile.out -covermode=atomic $d; if [ -f profile.out ]; then cat profile.out >> coverage.txt; rm profile.out; fi done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest use of multiline string (Block Scalar >) as described here for better visibility, but I'm not sure if it will work with Semaphore CI. Other than that all looks good to me, but Semaphore CI does not report a status... I guess something else should be adjusted as well. Do we have any logs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chombium We've decided not to switch to Semaphore 2 yet because it's still in Beta phase. This PR will add simple shell script that will be executed by Semaphore so that we can track CI commands changes.
Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
Codecov Report
@@ Coverage Diff @@
## master #541 +/- ##
==========================================
+ Coverage 87.17% 87.35% +0.18%
==========================================
Files 62 62
Lines 3297 3297
==========================================
+ Hits 2874 2880 +6
+ Misses 291 286 -5
+ Partials 132 131 -1
Continue to review full report at Codecov.
|
ae139cc
to
9d59eab
Compare
Add script explanation comment. Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add CI script Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com> * Fix indentetion Add script explanation comment. Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
* Add CI script Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com> * Fix indentetion Add script explanation comment. Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
* Add CI script Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com> * Fix indentetion Add script explanation comment. Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
Signed-off-by: Dusan Borovcanin dusan.borovcanin@mainflux.com.
What does this do?
This pull request adds a script to be executed by a CI tool.
Which issue(s) does this PR fix/relate to?
This pull request closes #370.