Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix pagination response for empty page #547

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

anovakovic01
Copy link
Contributor

Fix pagination response for the case when list is empty. API was returning null in some cases, now it will return empty list.

@codecov-io
Copy link

codecov-io commented Jan 17, 2019

Codecov Report

Merging #547 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
+ Coverage   87.35%   87.36%   +0.01%     
==========================================
  Files          62       62              
  Lines        3297     3301       +4     
==========================================
+ Hits         2880     2884       +4     
  Misses        286      286              
  Partials      131      131
Impacted Files Coverage Δ
things/api/http/endpoint.go 98.19% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6968f...86473b4. Read the comment docs.

Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dborovcanin dborovcanin merged commit f9f25e2 into absmach:master Jan 17, 2019
juanmagal pushed a commit to juanmagal/mainflux that referenced this pull request Feb 5, 2019
Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
davide83 pushed a commit to davide83/mainflux that referenced this pull request May 13, 2019
Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
manuio pushed a commit that referenced this pull request Oct 12, 2020
Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants