MF-429 -Enabled MQTT subtopic's #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmarcetic
requested review from
drasko,
dborovcanin,
anovakovic01,
manuio and
a user
Codecov Report
@@ Coverage Diff @@
## master #554 +/- ##
=======================================
Coverage 87.36% 87.36%
=======================================
Files 62 62
Lines 3301 3301
=======================================
Hits 2884 2884
Misses 286 286
Partials 131 131Continue to review full report at Codecov.
|
nmarcetic
changed the title
drasko
requested changes
Jan 25, 2019
drasko
reviewed
Jan 25, 2019
|
PLease sign the commits. |
manuio
previously requested changes
Jan 25, 2019
Signed-off-by: nmarcetic <n.marcetic86@gmail.com>
Signed-off-by: nmarcetic <n.marcetic86@gmail.com>
nmarcetic
force-pushed
the
feature/mqtt-subtopics
branch
from
2756ee3
to
327330a
Compare
Signed-off-by: nmarcetic <n.marcetic86@gmail.com>
nmarcetic
force-pushed
the
feature/mqtt-subtopics
branch
from
cfd7e12
to
018507d
Compare
Signed-off-by: nmarcetic <n.marcetic86@gmail.com>
|
It would be nice if we add some tests together with @RubenN and add few sentences in the docs ;) |
|
Yes, let me merge this and I will try to write a few words of doc. Tests are generally missing for MQTT adapter, and it would be good if @RubenN could help us with this. |
ghost
approved these changes
Jan 25, 2019
|
It's great to see how quickly some PRs getting reviewed and merged even on a Friday evening. Kudos to all of @mainflux/contributors ! I'm in a mood for few 🍻 and celebration now :) |
juanmagal
pushed a commit
to juanmagal/mainflux
that referenced
this pull request
Feb 1, 2019
* Enabled MQTT subtopic Signed-off-by: nmarcetic <n.marcetic86@gmail.com> * Removed debug logs Signed-off-by: nmarcetic <n.marcetic86@gmail.com> * Resolved remarks Signed-off-by: nmarcetic <n.marcetic86@gmail.com> * Resolved remarks Signed-off-by: nmarcetic <n.marcetic86@gmail.com>
juanmagal
pushed a commit
to juanmagal/mainflux
that referenced
this pull request
Feb 5, 2019
* Enabled MQTT subtopic Signed-off-by: nmarcetic <n.marcetic86@gmail.com> * Removed debug logs Signed-off-by: nmarcetic <n.marcetic86@gmail.com> * Resolved remarks Signed-off-by: nmarcetic <n.marcetic86@gmail.com> * Resolved remarks Signed-off-by: nmarcetic <n.marcetic86@gmail.com>
davide83
pushed a commit
to davide83/mainflux
that referenced
this pull request
May 13, 2019
* Enabled MQTT subtopic Signed-off-by: nmarcetic <n.marcetic86@gmail.com> * Removed debug logs Signed-off-by: nmarcetic <n.marcetic86@gmail.com> * Resolved remarks Signed-off-by: nmarcetic <n.marcetic86@gmail.com> * Resolved remarks Signed-off-by: nmarcetic <n.marcetic86@gmail.com>
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Enabled MQTT subtopic Signed-off-by: nmarcetic <n.marcetic86@gmail.com> * Removed debug logs Signed-off-by: nmarcetic <n.marcetic86@gmail.com> * Resolved remarks Signed-off-by: nmarcetic <n.marcetic86@gmail.com> * Resolved remarks Signed-off-by: nmarcetic <n.marcetic86@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
It enables MQTT subtopic's on multi level regarding to #429 feature request.
Which issue(s) does this PR fix/relate to ?
Resolves #429
List any changes that modify/break current functionality
No breaking changes.
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes
Subtopics are supported only for MQTT to MQTT communication or if you connect directly to NATS topics. Using other protocols or mixing it with MQTT is limited to general topic only
/messageswithout subtopics. Issues to support other protocol adapters will be opened.