Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF-519 - Refine Message #567

Merged
merged 3 commits into from
Feb 6, 2019
Merged

MF-519 - Refine Message #567

merged 3 commits into from
Feb 6, 2019

Conversation

dborovcanin
Copy link
Collaborator

What does this do?

This PR provides a workaround for marshaling and unmarshaling Mainflux Message to/from JSON.

Which issue(s) does this PR fix/relate to?

This PR resolves #519.

List any changes that modify/break current functionality

There are no such changes.

Notes

Methods are added to Message type so that it now implements JSON Marshaler and Unmarshaler interfaces.

@dborovcanin dborovcanin self-assigned this Feb 1, 2019
@codecov-io
Copy link

codecov-io commented Feb 1, 2019

Codecov Report

Merging #567 into master will decrease coverage by 0.28%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
- Coverage   87.21%   86.93%   -0.29%     
==========================================
  Files          62       62              
  Lines        3419     3391      -28     
==========================================
- Hits         2982     2948      -34     
- Misses        298      303       +5     
- Partials      139      140       +1
Impacted Files Coverage Δ
sdk/go/sdk.go 96.15% <ø> (ø) ⬆️
readers/api/responses.go 100% <ø> (ø) ⬆️
sdk/go/message.go 40.42% <0%> (ø) ⬆️
readers/api/endpoint.go 100% <100%> (ø) ⬆️
ws/api/transport.go 80% <0%> (-7.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df4dcd...eb0d83a. Read the comment docs.

message.proto Show resolved Hide resolved
message.proto Outdated Show resolved Hide resolved
drasko
drasko previously approved these changes Feb 6, 2019
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Update Protobuf generated files.

Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@anovakovic01 anovakovic01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nmarcetic nmarcetic merged commit 3f3b42b into absmach:master Feb 6, 2019
@nmarcetic nmarcetic mentioned this pull request Feb 11, 2019
dborovcanin added a commit to dborovcanin/magistrala that referenced this pull request Mar 4, 2019
* Enable Message JSON mashaling/unmarshaling

Update Protobuf generated files.

Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>

* Update readers and SDK to use Mainflux Message

Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>

* Fix alignment

Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
@dborovcanin dborovcanin deleted the MF-519 branch May 13, 2019 09:06
davide83 pushed a commit to davide83/mainflux that referenced this pull request May 13, 2019
* Enable Message JSON mashaling/unmarshaling

Update Protobuf generated files.

Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>

* Update readers and SDK to use Mainflux Message

Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>

* Fix alignment

Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
manuio pushed a commit that referenced this pull request Oct 12, 2020
* Enable Message JSON mashaling/unmarshaling

Update Protobuf generated files.

Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>

* Update readers and SDK to use Mainflux Message

Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>

* Fix alignment

Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine Message
6 participants