-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MF-519 - Refine Message #567
Conversation
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
==========================================
- Coverage 87.21% 86.93% -0.29%
==========================================
Files 62 62
Lines 3419 3391 -28
==========================================
- Hits 2982 2948 -34
- Misses 298 303 +5
- Partials 139 140 +1
Continue to review full report at Codecov.
|
a0c34d0
to
65fbe74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update Protobuf generated files. Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Enable Message JSON mashaling/unmarshaling Update Protobuf generated files. Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com> * Update readers and SDK to use Mainflux Message Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com> * Fix alignment Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
* Enable Message JSON mashaling/unmarshaling Update Protobuf generated files. Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com> * Update readers and SDK to use Mainflux Message Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com> * Fix alignment Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
* Enable Message JSON mashaling/unmarshaling Update Protobuf generated files. Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com> * Update readers and SDK to use Mainflux Message Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com> * Fix alignment Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
What does this do?
This PR provides a workaround for marshaling and unmarshaling Mainflux Message to/from JSON.
Which issue(s) does this PR fix/relate to?
This PR resolves #519.
List any changes that modify/break current functionality
There are no such changes.
Notes
Methods are added to Message type so that it now implements JSON
Marshaler
andUnmarshaler
interfaces.