Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF-597 - Removed legacy code as not needed anymore #598

Merged
merged 3 commits into from
Feb 15, 2019

Conversation

mteodor
Copy link
Contributor

@mteodor mteodor commented Feb 14, 2019

Signed-off-by: mteodor mirko.teodorovic@gmail.com

Pull request title should be MF-XXX - description or NOISSUE - description where XXX is ID of issue that this PR relate to.
Please review the CONTRIBUTING.md file for detailed contributing guidelines.

What does this do?

Removed legacy code as not needed anymore

Which issue(s) does this PR fix/relate to?

Put here Resolves #XXX to auto-close the issue that your PR fixes (if such)

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

Notes

Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
docker/Dockerfile Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Feb 14, 2019

Codecov Report

Merging #598 into master will decrease coverage by 1.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
- Coverage   88.22%   87.11%   -1.12%     
==========================================
  Files          62       62              
  Lines        3728     3391     -337     
==========================================
- Hits         3289     2954     -335     
+ Misses        299      298       -1     
+ Partials      140      139       -1
Impacted Files Coverage Δ
bootstrap/postgres/configs.go 75.77% <0%> (-6.87%) ⬇️
bootstrap/service.go 81.28% <0%> (-5.93%) ⬇️
bootstrap/api/requests.go 93.75% <0%> (-2.92%) ⬇️
bootstrap/api/transport.go 97.74% <0%> (-1.47%) ⬇️
bootstrap/api/endpoint.go 100% <0%> (ø) ⬆️
bootstrap/api/responses.go 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c418a9a...84b4029. Read the comment docs.

Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
docker/Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmarcetic nmarcetic merged commit 2ee0ed1 into absmach:master Feb 15, 2019
dborovcanin pushed a commit to dborovcanin/magistrala that referenced this pull request Mar 4, 2019
* Removed legacy code as not needed anymore

Signed-off-by: mteodor <mirko.teodorovic@gmail.com>

* Small correction

Signed-off-by: mteodor <mirko.teodorovic@gmail.com>

* Remove git as not needed

Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
davide83 pushed a commit to davide83/mainflux that referenced this pull request May 13, 2019
* Removed legacy code as not needed anymore

Signed-off-by: mteodor <mirko.teodorovic@gmail.com>

* Small correction

Signed-off-by: mteodor <mirko.teodorovic@gmail.com>

* Remove git as not needed

Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
@mteodor mteodor deleted the MF-597 branch September 22, 2020 10:38
manuio pushed a commit that referenced this pull request Oct 12, 2020
* Removed legacy code as not needed anymore

Signed-off-by: mteodor <mirko.teodorovic@gmail.com>

* Small correction

Signed-off-by: mteodor <mirko.teodorovic@gmail.com>

* Remove git as not needed

Signed-off-by: mteodor <mirko.teodorovic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants