MF-579 Things & Channels returns 404 when not found or ID is malformed, not 500 #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Starcevic <vstarcevic@gmail.com>
ghost
changed the title
|
@vstarcevic this is the expected behavior. |
anovakovic01
suggested changes
Mar 5, 2019
dborovcanin
requested changes
Mar 5, 2019
Signed-off-by: Vladimir Starcevic <vstarcevic@gmail.com>
ghost
dismissed
Codecov Report
@@ Coverage Diff @@
## master #633 +/- ##
==========================================
- Coverage 86.72% 86.67% -0.05%
==========================================
Files 62 62
Lines 3623 3625 +2
==========================================
Hits 3142 3142
- Misses 327 329 +2
Partials 154 154
Continue to review full report at Codecov.
|
manuio
previously approved these changes
Mar 5, 2019
…rmed not 500 Signed-off-by: Vladimir Starcevic <vstarcevic@gmail.com>
dborovcanin
reviewed
Mar 6, 2019
…d, not 500 Signed-off-by: Vladimir Starcevic <vstarcevic@gmail.com>
ghost
changed the title
manuio
approved these changes
Mar 6, 2019
dborovcanin
approved these changes
Mar 6, 2019
davide83
pushed a commit
to davide83/mainflux
that referenced
this pull request
May 13, 2019
…d, not 500 (absmach#633) * Things returns 404 when not found, not 500 Signed-off-by: Vladimir Starcevic <vstarcevic@gmail.com> * MF-579 Things returns 404 when not found or thingid is in invalid format Signed-off-by: Vladimir Starcevic <vstarcevic@gmail.com> * MF-579 Things and channels returns 404 when not found, or ID is malformed not 500 Signed-off-by: Vladimir Starcevic <vstarcevic@gmail.com> * MF-579 Things & Channels returns 404 when not found or ID is malformed, not 500 Signed-off-by: Vladimir Starcevic <vstarcevic@gmail.com>
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
…d, not 500 (#633) * Things returns 404 when not found, not 500 Signed-off-by: Vladimir Starcevic <vstarcevic@gmail.com> * MF-579 Things returns 404 when not found or thingid is in invalid format Signed-off-by: Vladimir Starcevic <vstarcevic@gmail.com> * MF-579 Things and channels returns 404 when not found, or ID is malformed not 500 Signed-off-by: Vladimir Starcevic <vstarcevic@gmail.com> * MF-579 Things & Channels returns 404 when not found or ID is malformed, not 500 Signed-off-by: Vladimir Starcevic <vstarcevic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vladimir Starcevic vstarcevic@gmail.com
What does this do?
Retrieving things or channels by Id, returns 404 when not found or id is malformed, not 500
Which issue(s) does this PR fix/relate to?
Resolves #579
List any changes that modify/break current functionality
NA
Have you included tests for your changes?
Yes
Did you document any new/modified functionality?
NA
Notes