Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF-656 - Change bootstrap service port to 8200 #658

Merged
merged 2 commits into from
Mar 18, 2019

Conversation

anovakovic01
Copy link
Contributor

What does this do?

Changes bootstrap service port to 8200.

Which issue(s) does this PR fix/relate to?

Resolves #656.

List any changes that modify/break current functionality

Bootstrap service port is moved from port 8900 to 8200.

Have you included tests for your changes?

No.

Did you document any new/modified functionality?

Existing documentation is updated.

Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
dborovcanin
dborovcanin previously approved these changes Mar 18, 2019
nmarcetic
nmarcetic previously approved these changes Mar 18, 2019
drasko
drasko previously approved these changes Mar 18, 2019
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
@codecov-io
Copy link

Codecov Report

Merging #658 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
- Coverage   86.66%   86.35%   -0.32%     
==========================================
  Files          62       62              
  Lines        3779     3707      -72     
==========================================
- Hits         3275     3201      -74     
- Misses        346      348       +2     
  Partials      158      158
Impacted Files Coverage Δ
users/api/http/transport.go 83.6% <0%> (-3.58%) ⬇️
things/service.go 92.85% <0%> (-1.3%) ⬇️
things/api/http/transport.go 98.03% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed1471...b5f5afa. Read the comment docs.

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmarcetic nmarcetic merged commit 8c3bff5 into absmach:master Mar 18, 2019
davide83 pushed a commit to davide83/mainflux that referenced this pull request May 13, 2019
* Change bootstrap service port to 8200

Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>

* Fix redis streams tests in things service

Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
manuio pushed a commit that referenced this pull request Oct 12, 2020
* Change bootstrap service port to 8200

Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>

* Fix redis streams tests in things service

Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The bootstrap servcice runs on the same port as the influxdb-writer
5 participants