NOISSUE - Fix subtopic regex and restrict empty subtopic parts #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuio
previously approved these changes
Mar 18, 2019
Codecov Report
@@ Coverage Diff @@
## master #659 +/- ##
==========================================
- Coverage 86.66% 86.29% -0.37%
==========================================
Files 62 62
Lines 3779 3722 -57
==========================================
- Hits 3275 3212 -63
- Misses 346 353 +7
+ Partials 158 157 -1
Continue to review full report at Codecov.
|
anovakovic01
force-pushed
the
NOISSUE-fix-subtopic
branch
2 times, most recently
from
8fa091a
to
c0ec95b
Compare
drasko
requested changes
Mar 19, 2019
added 8 commits
March 19, 2019 12:53
Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
anovakovic01
force-pushed
the
NOISSUE-fix-subtopic
branch
from
674ab68
to
bf5bc3b
Compare
nmarcetic
approved these changes
Mar 19, 2019
|
LGTM |
dborovcanin
approved these changes
Mar 19, 2019
davide83
pushed a commit
to davide83/mainflux
that referenced
this pull request
May 13, 2019
…ch#659) * Fix subtopic regex and restrict empty subtopic parts Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Update mqtt adapter subtopic processing Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Return old MQTT adapter implementation Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Allow dots and handle empty parts Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Add malformed subtopic error encoding Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Fix MQTT topic validation Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Fix MQTT topic parsing Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Fix subtopic filtering Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Fix subtopic regex and restrict empty subtopic parts Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Update mqtt adapter subtopic processing Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Return old MQTT adapter implementation Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Allow dots and handle empty parts Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Add malformed subtopic error encoding Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Fix MQTT topic validation Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Fix MQTT topic parsing Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Fix subtopic filtering Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
It restricts publish and subscribe to subtopic that contains
*or>inside topic part.Have you included tests for your changes?
No.
Did you document any new/modified functionality?
No.