Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF-662 - Change menu style #678

Merged
merged 4 commits into from
Apr 2, 2019
Merged

MF-662 - Change menu style #678

merged 4 commits into from
Apr 2, 2019

Conversation

blokovi
Copy link
Contributor

@blokovi blokovi commented Mar 29, 2019

What does this do?

Change menu style:

  • update menu from bootstrap button group to bootstrap nav
  • highlight selected item

Which issue(s) does this PR fix/relate to?

Resolves #662

@codecov-io
Copy link

codecov-io commented Mar 29, 2019

Codecov Report

Merging #678 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
+ Coverage   86.29%   86.35%   +0.05%     
==========================================
  Files          62       62              
  Lines        3722     3722              
==========================================
+ Hits         3212     3214       +2     
+ Misses        353      352       -1     
+ Partials      157      156       -1
Impacted Files Coverage Δ
writers/cassandra/init.go 80% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9b17d5...77872a6. Read the comment docs.

drasko
drasko previously approved these changes Mar 30, 2019
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

darkodraskovic
darkodraskovic previously approved these changes Apr 1, 2019
Copy link
Contributor

@darkodraskovic darkodraskovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

darkodraskovic
darkodraskovic previously approved these changes Apr 2, 2019
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
This reverts commit 205e13b.

Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 56a5096 into absmach:master Apr 2, 2019
davide83 pushed a commit to davide83/mainflux that referenced this pull request May 13, 2019
* env variable for local dev

Signed-off-by: Ivan Milošević <iva@blokovi.com>

* Change menu style

Signed-off-by: Ivan Milošević <iva@blokovi.com>

* Revert "env variable for local dev"

This reverts commit 205e13b.

Signed-off-by: Ivan Milošević <iva@blokovi.com>

* Move font awesome class names to record in Helper

Signed-off-by: Ivan Milošević <iva@blokovi.com>
@blokovi blokovi deleted the MF-662 branch May 24, 2019 09:55
manuio pushed a commit that referenced this pull request Oct 12, 2020
* env variable for local dev

Signed-off-by: Ivan Milošević <iva@blokovi.com>

* Change menu style

Signed-off-by: Ivan Milošević <iva@blokovi.com>

* Revert "env variable for local dev"

This reverts commit 205e13b.

Signed-off-by: Ivan Milošević <iva@blokovi.com>

* Move font awesome class names to record in Helper

Signed-off-by: Ivan Milošević <iva@blokovi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the menu
5 participants