MF-673 - Fix offset calculation after deleting thing or channel #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ative offset after deleting last thing/channel Signed-off-by: Ivan Milošević <iva@blokovi.com>
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
==========================================
+ Coverage 86.24% 86.29% +0.05%
==========================================
Files 62 62
Lines 3722 3722
==========================================
+ Hits 3210 3212 +2
+ Misses 355 353 -2
Partials 157 157
Continue to review full report at Codecov.
|
dborovcanin
approved these changes
Apr 1, 2019
nattaponra
pushed a commit
to nattaponra/mainflux
that referenced
this pull request
Apr 6, 2019
…ative offset after deleting last thing/channel (absmach#679) Signed-off-by: Ivan Milošević <iva@blokovi.com> Signed-off-by: Nattapon Rakthong <nattapon.rakthong@gmail.com>
davide83
pushed a commit
to davide83/mainflux
that referenced
this pull request
May 13, 2019
…ative offset after deleting last thing/channel (absmach#679) Signed-off-by: Ivan Milošević <iva@blokovi.com>
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
…ative offset after deleting last thing/channel (#679) Signed-off-by: Ivan Milošević <iva@blokovi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ivan Milošević iva@blokovi.com
What does this do?
Fix offset calculation after deleting thing/channel, not to go to negative offset after deleting last thing/channel
Which issue(s) does this PR fix/relate to?
Resolves #673