Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MF-688 - InfluxDB writer invalid time parsing #689

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

dborovcanin
Copy link
Collaborator

What does this do?

This pull request fixes invalid time parse in InfluxDB writer.

Which issue(s) does this PR fix/relate to?

This pull request fixes #688.

List any changes that modify/break current functionality

There are no such changes.

Have you included tests for your changes?

No, this is a simple fix.

Did you document any new/modified functionality?

No, since this is just a fix of the already documented feature.

@dborovcanin dborovcanin self-assigned this Apr 4, 2019
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
@codecov-io
Copy link

codecov-io commented Apr 4, 2019

Codecov Report

Merging #689 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #689      +/-   ##
=========================================
+ Coverage   86.29%   86.3%   +<.01%     
=========================================
  Files          62      62              
  Lines        3722    3723       +1     
=========================================
+ Hits         3212    3213       +1     
  Misses        353     353              
  Partials      157     157
Impacted Files Coverage Δ
writers/influxdb/messages.go 85.91% <100%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f62f89...9ba805c. Read the comment docs.

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit e4d3b1d into absmach:master Apr 4, 2019
drasko pushed a commit to drasko/mainflux that referenced this pull request Apr 4, 2019
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
drasko pushed a commit to drasko/mainflux that referenced this pull request Apr 4, 2019
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
davide83 pushed a commit to davide83/mainflux that referenced this pull request May 13, 2019
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
@dborovcanin dborovcanin deleted the MF-688 branch September 30, 2019 12:44
manuio pushed a commit that referenced this pull request Oct 12, 2020
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InfluxDB writer invalid time parsing
4 participants