MF-715 - Conflict on updating connection with a valid list of channels #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dborovcanin
changed the title
drasko
changed the title
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
==========================================
- Coverage 85.71% 85.58% -0.13%
==========================================
Files 64 64
Lines 4019 4011 -8
==========================================
- Hits 3445 3433 -12
- Misses 393 395 +2
- Partials 181 183 +2
Continue to review full report at Codecov.
|
dborovcanin
force-pushed
the
fix/bs
branch
5 times, most recently
from
f471682
to
8a2df4e
Compare
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
ghost
approved these changes
Apr 17, 2019
nmarcetic
approved these changes
Apr 17, 2019
davide83
pushed a commit
to davide83/mainflux
that referenced
this pull request
May 13, 2019
absmach#716) * Add check if Channels already exist Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Update streams tests to use time offset Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
rugwirobaker
pushed a commit
to rugwirobaker/mainflux
that referenced
this pull request
Jun 26, 2019
absmach#716) * Add check if Channels already exist Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Update streams tests to use time offset Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
#716) * Add check if Channels already exist Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Update streams tests to use time offset Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This pull request checks if some of the channels added during connections update already exist.
Which issue(s) does this PR fix/relate to?
This pull request resolves #715.
Have you included tests for your changes?
Yes, I've updated tests.