-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MF-711 - Create separate Redis instance for ES #717
Conversation
Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #717 +/- ##
=======================================
Coverage 85.71% 85.71%
=======================================
Files 64 64
Lines 4019 4019
=======================================
Hits 3445 3445
Misses 393 393
Partials 181 181 Continue to review full report at Codecov.
|
* Fix Redis connection error handling in MQTT adapter Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Add separate env vars for ES in MQTT adapter Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Create dedicated redis service for ES Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Update docs according to changes Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
* Fix Redis connection error handling in MQTT adapter Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Add separate env vars for ES in MQTT adapter Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Create dedicated redis service for ES Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Update docs according to changes Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
* Fix Redis connection error handling in MQTT adapter Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Add separate env vars for ES in MQTT adapter Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Create dedicated redis service for ES Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Update docs according to changes Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
What does this do?
Separates ES from Aedes Redis in MQTT adapter. It also creates a separate Redis instance for ES.
Which issue(s) does this PR fix/relate to?
Resolves #711.
List any changes that modify/break current functionality
There is a separate env var for ES in MQTT adapter now.
Have you included tests for your changes?
No.
Did you document any new/modified functionality?
I've updated current docs.