MF-488 - Remove Thing type (app or device) #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #718 +/- ##
==========================================
- Coverage 86.59% 85.32% -1.28%
==========================================
Files 64 64
Lines 4372 3993 -379
==========================================
- Hits 3786 3407 -379
+ Misses 400 399 -1
- Partials 186 187 +1
Continue to review full report at Codecov.
|
anovakovic01
suggested changes
Apr 18, 2019
docs/getting-started.md
Outdated
| This proves that messages have been well send through the system, via protocol adapter (`mainflux-http`) and `normalizer` service which corectly parsed messages. |
things/api/http/endpoint_test.go
Outdated
| @@ -35,7 +35,7 @@ const ( | |||
| ) | |||
|
|
|||
| var ( | |||
| thing = things.Thing{Type: "app", Name: "test_app", Metadata: map[string]interface{}{"test": "data"}} | |||
| thing = things.Thing{ Name: "test_app", Metadata: map[string]interface{}{"test": "data"}} | |||
There was a problem hiding this comment.
Remove extra space in front of Name:.
|
@anovakovic01 sure :) I'm starting right now |
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
dborovcanin
reviewed
Apr 19, 2019
There was a problem hiding this comment.
Please check these files as well:
https://github.com/mainflux/mainflux/blob/master/things/README.md#things (remove (i.e. devices & applications) part)
https://github.com/mainflux/mainflux/blob/master/docs/dev-guide.md#thing-create-event and https://github.com/mainflux/mainflux/blob/master/docs/dev-guide.md#thing-create-event (remove type field from event examples)
Great job, @manuio.
sdk/go/things_test.go
Outdated
| @@ -87,6 +87,13 @@ func TestCreateThing(t *testing.T) { | |||
| err: nil, | |||
| location: "1", | |||
| }, | |||
| { | |||
| desc: "create new epmty thing", | |||
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
dborovcanin
approved these changes
Apr 19, 2019
davide83
pushed a commit
to davide83/mainflux
that referenced
this pull request
May 13, 2019
* MF-488 - Remove Thing type (app or device) Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Typo fix Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix reviews Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix reviews Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix reviews Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
rugwirobaker
pushed a commit
to rugwirobaker/mainflux
that referenced
this pull request
Jun 26, 2019
* MF-488 - Remove Thing type (app or device) Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Typo fix Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix reviews Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix reviews Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix reviews Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
manuio
added a commit
that referenced
this pull request
Oct 12, 2020
* MF-488 - Remove Thing type (app or device) Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Typo fix Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix reviews Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix reviews Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix reviews Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com